Remove unused variables from RecoVertex/BeamSpotProducer

[Dr15Jones]

PR description:

This fixes a clang warning.

PR validation:

Code compiles under clang without issuing warnings.

[Dr15Jones]

This was only commented out instead of deleted since a few lines below there is commented out code which uses that variable.

[Dr15Jones]

please test

[Dr15Jones]

@makortel FYI

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-40800/34231

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @Dr15Jones (Chris Jones) for master.

It involves the following packages:

• RecoVertex/BeamSpotProducer (reconstruction, alca)

@malbouis, @yuanchao, @ChrisMisan, @clacaputo, @saumyaphor4252, @tvami, @mandrenguyen, @francescobrivio can you please review it and eventually sign? Thanks.
@VourMa, @GiacomoSguazzoni, @JanFSchulte, @tocheng, @VinInn, @missirol, @rovere, @mmusich, @mtosi, @dgulhan, @francescobrivio this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-84bdc9/30690/summary.html
COMMIT: 96f2552
CMSSW: CMSSW_13_1_X_2023-02-16-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/40800/30690/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 10 lines to the logs
• Reco comparison results: 4 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3556272
• DQMHistoTests: Total failures: 4
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3556246
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 213 log files, 164 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[francescobrivio]

+1

• cleanup of unused variables
• tests ok

[clacaputo]

+reconstruction

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[perrotta]

+1