Fix check for valid type with dictionary #4094
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relval matrix test 1001 is failing with a segfault. The segfault is due to two things:
This pull request fixes the invalid check, so that test 1001 will throw a proper exception due to the missing dictionary. The missing dictionary will be added lter in a separate pull request.
This pull request also converts many calls to abort(), used for testing purposes, to throw exceptions instead.
Please merge promptly unless there are issues.