Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix check for valid type with dictionary #4094

Merged
merged 1 commit into from Jun 3, 2014

Conversation

wmtan
Copy link
Contributor

@wmtan wmtan commented Jun 3, 2014

Relval matrix test 1001 is failing with a segfault. The segfault is due to two things:

  1. A missing dictionary for a class that needs a TypeWithDict constructed
  2. An incorrect check in TypeWithDict for the presence of the dictionary.
    This pull request fixes the invalid check, so that test 1001 will throw a proper exception due to the missing dictionary. The missing dictionary will be added lter in a separate pull request.
    This pull request also converts many calls to abort(), used for testing purposes, to throw exceptions instead.
    Please merge promptly unless there are issues.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 3, 2014

A new Pull Request was created by @wmtan for CMSSW_7_2_ROOT6_X.

Fix check for valid type with dictionary

It involves the following packages:

DataFormats/Provenance
FWCore/Utilities

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

davidlt added a commit that referenced this pull request Jun 3, 2014
Fix check for valid type with dictionary
@davidlt davidlt merged commit 7f4717c into cms-sw:CMSSW_7_2_ROOT6_X Jun 3, 2014
@wmtan wmtan deleted the FixCheckForValidType branch June 3, 2014 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants