move the Vx3DHLTAnalyzer class to the DQMEDAnalyzer interface #4106
Conversation
|
+1 |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests. |
|
Please write a sensible description. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
|
Please fix the title or I will not merge this. |
|
This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine). |
|
To be clear: until this pull request gets a decent description, it will not be merged. |
deguio
changed the title
|
I changed the title. should be fine now. |
Move the Vx3DHLTAnalyzer class to the DQMEDAnalyzer interface
| @@ -166,7 +174,7 @@ unsigned int Vx3DHLTAnalyzer::HitCounter(const Event& iEvent) | |||
|
|
|||
| char* Vx3DHLTAnalyzer::formatTime (const time_t& t) | |||
| { | |||
| static char ts[25]; | |||
There was a problem hiding this comment.
This is wrong. The string will not be copied.
There was a problem hiding this comment.
my fault. I overlooked the fact that it is a pointer. the easy fix is to copy into an std::string and return that one by value. I'll patch later today.
thanks for noticing this,
F.
this PR supersedes #4048