Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gem geometry printout #4132

Merged
merged 2 commits into from Jun 6, 2014
Merged

Fix gem geometry printout #4132

merged 2 commits into from Jun 6, 2014

Conversation

dildick
Copy link
Contributor

@dildick dildick commented Jun 6, 2014

No description provided.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2014

A new Pull Request was created by @dildick (Sven Dildick) for CMSSW_6_2_X_SLHC.

Fix gem geometry printout

It involves the following packages:

Geometry/GEMGeometry

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor

ianna commented Jun 6, 2014

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 6, 2014

This pull request is fully signed and it will be integrated in one of the next CMSSW_6_2_X_SLHC IBs unless changes or unless it breaks tests. @fratnikov, @mark-grimes can you please take care of it?

nsmith- pushed a commit to nsmith-/cmssw that referenced this pull request Jun 6, 2014
Add TrackingParticle selector (fix for cms-sw#4132)
@fratnikov
Copy link

tests passed:

runTheMatrix.py -w upgrade -l 10000,10200,10400,11200,11400,12000,12400,12800,13000,13600,13800,14000,14600
13 13 12 12 tests passed, 0 0 0 0 failed

runTheMatrix.py -w upgrade -l 12600,12200,14200,14400
4 3 0 0 tests passed, 0 1 3 0 failed

@fratnikov
Copy link

merge

cmsbuild added a commit that referenced this pull request Jun 6, 2014
@cmsbuild cmsbuild merged commit 582b8cc into cms-sw:CMSSW_6_2_X_SLHC Jun 6, 2014
@dildick dildick deleted the fix-gem-geometry-printout branch April 30, 2016 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants