Backport to 13_0_X of #41275 Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano #41434

AnnikaStein · 2023-04-26T17:36:37Z

PR description:

See description of #41275 - new tagger for Run 3 for MiniAOD and NanoAOD, update of DeepJet for Run 3, and removing outdated DeepCSV for Run 3.
Additions are verbatim copies of original PR, modifications have been updated to be in line with latest PNet additions into the same packages.

PR validation:

Compilation, basic checks similar to original PR.

scram b runtests
scram build code-checks
scram build code-format
scram build updateclassversion

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Backport of #41275

cmsbuild · 2023-04-26T17:37:05Z

A new Pull Request was created by @AnnikaStein (Annika Stein) for CMSSW_13_0_X.

It involves the following packages:

DataFormats/BTauReco (reconstruction)
PhysicsTools/NanoAOD (xpog)
PhysicsTools/PatAlgos (xpog, reconstruction)
RecoBTag/Configuration (reconstruction)
RecoBTag/FeatureTools (reconstruction)
RecoBTag/ONNXRuntime (reconstruction)

@swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please review it and eventually sign? Thanks.
@rappoccio, @gouskos, @hatakeyamak, @emilbols, @mbluj, @demuller, @seemasharmafnal, @mmarionncern, @missirol, @ahinzmann, @jdolen, @azotz, @hqucms, @rovere, @jdamgov, @nhanvtran, @gkasieczka, @schoef, @andrzejnovak, @AlexDeMoor, @AnnikaStein, @JyothsnaKomaragiri, @gpetruc, @mariadalfonso this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

Backported from Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano #41275

cmsbuild · 2023-04-26T17:58:05Z

Pull request #41434 was updated. @swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please check and sign again.

cmsbuild · 2023-04-27T06:46:53Z

Pull request #41434 was updated. @swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please check and sign again.

perrotta · 2023-04-27T12:02:31Z

backport of #41275

simonepigazzini · 2023-04-27T20:10:13Z

enable nano

simonepigazzini · 2023-04-27T20:10:23Z

please test

cmsbuild · 2023-04-27T21:29:57Z

-1

Failed Tests: RelVals RelVals-INPUT RelVals-NANO AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58a9be/32208/summary.html
COMMIT: 9193655
CMSSW: CMSSW_13_0_X_2023-04-27-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

136.8311

----- Begin Fatal Exception 27-Apr-2023 22:43:27 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV04_12X_training/DeepJet_Run3_122X.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.8311_RunJetHT2017FreMINIAOD


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Mixins.py(511): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Config.py(1212): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Config.py(1478): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

136.7611

----- Begin Fatal Exception 27-Apr-2023 22:43:27 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV04_12X_training/DeepJet_Run3_122X.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.7611_RunJetHT2016EreMINIAOD


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Mixins.py(511): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Config.py(1212): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Config.py(1478): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

136.88811

----- Begin Fatal Exception 27-Apr-2023 22:43:28 CEST-----------------------
An exception of category 'ConfigFileReadError' occurred while
   [0] Processing the python configuration file named step2_PAT_DQM.py
Exception Message:
 unknown python problem occurred.
RuntimeError: An exception of category 'FileInPathError' occurred.
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV04_12X_training/DeepJet_Run3_122X.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-relvals/matrix-results/136.88811_RunJetHT2018DreMINIAODUL


At:
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Types.py(840): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Mixins.py(376): insertContentsInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Mixins.py(511): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Modules.py(161): insertInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Config.py(1212): _insertManyInto
  /cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src/FWCore/ParameterSet/python/Config.py(1478): fillProcessDesc
  <string>(2): <module>

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

4.64.6_MinimumBias2010A/step2_MinimumBias2010A.log
136.72412136.72412_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log
136.72411136.72411_RunJetHT2016B_reminiaodUL/step2_RunJetHT2016B_reminiaodUL.log

Expand to see more relval errors ...

RelVals-NANO

2500.5012500.501_NANOmc124Xrun3/step2_NANOmc124Xrun3.log
2500.4012500.401_NANOmc122Xrun3/step2_NANOmc122Xrun3.log
2500.5112500.511_NANOdata124Xrun3/step2_NANOdata124Xrun3.log

Expand to see more relval errors ...

AddOn Tests

hlt_mc_GRun

----- Begin Fatal Exception 27-Apr-2023 22:46:18 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV04_12X_training/DeepJet_Run3_122X.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_GRun
----- End Fatal Exception -------------------------------------------------

hlt_mc_GRun

----- Begin Fatal Exception 27-Apr-2023 22:47:39 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV04_12X_training/DeepJet_Run3_122X.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_mc_GRun
----- End Fatal Exception -------------------------------------------------

hlt_data_GRun

----- Begin Fatal Exception 27-Apr-2023 22:44:22 CEST-----------------------
An exception of category 'FileInPathError' occurred while
   [0] Constructing the EventProcessor
Exception Message:
edm::FileInPath unable to find file RecoBTag/Combined/data/DeepFlavourV04_12X_training/DeepJet_Run3_122X.onnx anywhere in the search path.
The search path is defined by: CMSSW_SEARCH_PATH
${CMSSW_SEARCH_PATH} is: /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/poison:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/src:/cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41434/32208/CMSSW_13_0_X_2023-04-27-1100/external/el8_amd64_gcc11/data:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/poison:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/src:/cvmfs/cms-ib.cern.ch/sw/x86_64/nweek-02782/el8_amd64_gcc11/cms/cmssw-patch/CMSSW_13_0_X_2023-04-27-1100/external/el8_amd64_gcc11/data
Current directory is: /data/cmsbld/jenkins/workspace/ib-run-pr-addon/addOnTests/hlt_data_GRun
----- End Fatal Exception -------------------------------------------------

Expand to see more addon errors ...

hlt_data_GRun

cmsbuild · 2023-04-29T11:21:38Z

Pull request #41434 was updated. @swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please check and sign again.

AnnikaStein · 2023-04-29T20:49:46Z

We would need to test this with the model files (cms-data/RecoBTag-Combined#51 - updated to use the adversarial model weights for ParTAK4, otherwise same usage with DeepJet for Run 3).

The suggested changes from the original PR (c857a54) have been included here as well today for the backport.

cmsbuild · 2023-05-03T14:23:08Z

Pull request #41434 was updated. @swertz, @vlimant, @clacaputo, @cmsbuild, @simonepigazzini, @mandrenguyen can you please check and sign again.

simonepigazzini · 2023-05-03T14:24:32Z

please test

AnnikaStein · 2023-05-03T14:25:53Z

Noticed there were additional keywords which are unknown to the modifier, which resulted in these workflows failing (https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58a9be/32341/runTheMatrixNANO-results/wf_errors.txt)

KeyError: 'Unknown parameter name btagRobustPartAK4CvL specified while calling Modifier'

apologies for that, must have happened while adapting to the recently merged PR

cmsbuild · 2023-05-03T17:43:49Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58a9be/32346/summary.html
COMMIT: 69f0e3b
CMSSW: CMSSW_13_0_X_2023-05-03-1100/el8_amd64_gcc11
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41434/32346/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@mmusich [13.0.X] add PileupSummaryInfos_addPileupInfo to SiPixelCalSingleMuonTight output data-tier #41484

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58a9be/32346/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-58a9be/32346/git-merge-result

Comparison Summary

Summary:

You potentially added 19 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 1091 differences found in the comparisons
DQMHistoTests: Total files compared: 49
DQMHistoTests: Total histograms compared: 3554559
DQMHistoTests: Total failures: 1778
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3552759
DQMHistoTests: Total skipped: 22
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: -3.5940000000000007 KiB( 48 files compared)
DQMHistoSizes: changed ( 11634.0,... ): -0.438 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 13234.0,... ): -0.264 KiB Physics/NanoAODDQM
Checked 213 log files, 164 edm output root files, 49 DQM output files
TriggerResults: no differences found

NANO Comparison Summary

Summary:

You potentially added 19 lines to the logs
ROOTFileChecks: Some differences in event products or their sizes found
Reco comparison results: 15 differences found in the comparisons
DQMHistoTests: Total files compared: 12
DQMHistoTests: Total histograms compared: 12171
DQMHistoTests: Total failures: 0
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 12171
DQMHistoTests: Total skipped: 0
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 11.106000000000003 KiB( 11 files compared)
DQMHistoSizes: changed ( 2500.311,... ): 2.696 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 2500.331,... ): 1.620 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 2500.401,... ): -0.438 KiB Physics/NanoAODDQM
DQMHistoSizes: changed ( 2500.5111,... ): -0.264 KiB Physics/NanoAODDQM
Checked 25 log files, 11 edm output root files, 12 DQM output files

Nano size comparison Summary:

Sample	kb/ev	ref kb/ev	diff kb/ev	ev/s/thd	ref ev/s/thd	diff rate	mem/thd	ref mem/thd
2500.31	2.438	2.387	0.051 ( +2.1% )	5.21	5.55	-6.0%	1.481	1.477
2500.311	2.545	2.487	0.058 ( +2.3% )	4.67	5.00	-6.6%	1.875	1.873
2500.312	2.491	2.437	0.054 ( +2.2% )	4.87	5.18	-6.1%	1.861	1.861
2500.33	1.240	1.206	0.034 ( +2.8% )	9.89	10.56	-6.3%	1.671	1.656
2500.331	1.603	1.550	0.054 ( +3.5% )	5.26	5.72	-8.0%	1.833	1.818
2500.332	1.485	1.444	0.041 ( +2.9% )	7.59	8.14	-6.7%	1.861	1.849
2500.401	2.153	2.184	-0.030 ( -1.4% )	5.28	5.33	-1.0%	1.340	1.353
2500.501	1.752	1.768	-0.017 ( -0.9% )	9.12	9.03	+1.0%	1.256	1.255
2500.511	1.144	1.162	-0.018 ( -1.5% )	4.42	4.48	-1.4%	1.553	1.576
2500.5111	1.502	1.520	-0.018 ( -1.2% )	3.88	3.90	-0.6%	1.599	1.629
2500.601	2.014	2.049	-0.035 ( -1.7% )	12.78	12.83	-0.4%	1.146	1.152

AnnikaStein · 2023-05-04T14:59:44Z

Are there any open points for this backport? From our perspective, the tests produced the expected results, similar to the ones in the PR for master, where the outdated DeepCSV gets removed successfully, replaced by a new version of DeepJet (which causes differences in the comparisons) and RobustParTAK4 (which is not yet rerun for early-Run3 samples as we anticipate that re-mini happens).
And do we now need a backport of the original PR to 13_1X, as the milestone has been changed just before merging the original?

perrotta · 2023-05-04T15:03:05Z

And do we now need a backport of the original PR to 13_1X, as the milestone has been changed just before merging the original?

Hi @AnnikaStein
Yes, whatever you want to backport from 13_2_X to 13_0_X must consider also a backport in the intermediate release cycle 13_1_X

AlexDeMoor · 2023-05-04T15:05:04Z

By the way the model's PR has not yet been merged : cms-data/RecoBTag-Combined#51
@simonepigazzini and @perrotta , what is the procedure about it ?

perrotta · 2023-05-04T15:16:39Z

By the way the model's PR has not yet been merged : cms-data/RecoBTag-Combined#51 @simonepigazzini and @perrotta , what is the procedure about it ?

I just prepared the backport cmsdist PR for 13_0_X: cms-sw/cmsdist#8493
To be merged together with this CMSSW PR

perrotta · 2023-05-04T15:23:31Z

test parameters:

pull_request = Update tag for RecoBTag-Combined to V01-17-00 [CMSSW_13_0_X] cmsdist#8493

simonepigazzini · 2023-05-05T07:36:55Z

+1

clacaputo · 2023-05-08T13:52:46Z

+reconstruction

rappoccio · 2023-05-09T13:24:15Z

+1

AnnikaStein added 3 commits April 26, 2023 18:34

DataFormats/BTauReco

c6b5e4e

RecoBTag

0bf9c33

PhysicsTools/NanoAOD and /PatAlgos

bf42e3b

cmsbuild added this to the CMSSW_13_0_X milestone Apr 26, 2023

cmsbuild added reconstruction-pending pending-signatures tests-pending orp-pending xpog-pending labels Apr 26, 2023

Merge branch 'CMSSW_13_0_X' into from-CMSSW_13_0_3

d12681a

code-format

9193655

AnnikaStein marked this pull request as ready for review April 27, 2023 06:47

cmsbuild added the backport label Apr 27, 2023

cmsbuild added tests-started and removed tests-pending labels Apr 27, 2023

cmsbuild added tests-rejected and removed tests-started labels Apr 27, 2023

Add modifications respecting comments

07e397f

cmsbuild added tests-pending and removed tests-rejected labels Apr 29, 2023

AnnikaStein mentioned this pull request Apr 29, 2023

Add 122X trainings of DeepJet and ParTAK4 cms-data/RecoBTag-Combined#51

Merged

cmsbuild added the tests-pending label May 3, 2023

cmsbuild added tests-started and removed tests-pending labels May 3, 2023

cmsbuild added tests-approved backport-ok and removed tests-started backport labels May 3, 2023

perrotta mentioned this pull request May 4, 2023

Update tag for RecoBTag-Combined to V01-17-00 [CMSSW_13_0_X] cms-sw/cmsdist#8493

Merged

cmsbuild added xpog-approved and removed xpog-pending labels May 5, 2023

cmsbuild added reconstruction-approved fully-signed and removed reconstruction-pending pending-signatures labels May 8, 2023

cmsbuild added orp-approved and removed orp-pending labels May 9, 2023

cmsbuild merged commit afd432f into cms-sw:CMSSW_13_0_X May 9, 2023
13 checks passed

mmusich mentioned this pull request May 10, 2023

[13_0_X] Update run3 data GTs #41611

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Backport to 13_0_X of #41275 Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano #41434

Backport to 13_0_X of #41275 Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano #41434

AnnikaStein commented Apr 26, 2023 •

edited

cmsbuild commented Apr 26, 2023 •

edited

cmsbuild commented Apr 26, 2023

cmsbuild commented Apr 27, 2023

perrotta commented Apr 27, 2023

simonepigazzini commented Apr 27, 2023

simonepigazzini commented Apr 27, 2023

cmsbuild commented Apr 27, 2023

cmsbuild commented Apr 29, 2023

AnnikaStein commented Apr 29, 2023

cmsbuild commented May 3, 2023

simonepigazzini commented May 3, 2023

AnnikaStein commented May 3, 2023

cmsbuild commented May 3, 2023

AnnikaStein commented May 4, 2023

perrotta commented May 4, 2023

AlexDeMoor commented May 4, 2023

perrotta commented May 4, 2023

perrotta commented May 4, 2023

simonepigazzini commented May 5, 2023

clacaputo commented May 8, 2023

rappoccio commented May 9, 2023

Backport to 13_0_X of #41275 Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano #41434

Backport to 13_0_X of #41275 Introduce (Robust)ParTAK4 jet tagger, DeepJet model update for Run 3, remove DeepCSV from nano #41434

Conversation

AnnikaStein commented Apr 26, 2023 • edited

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Apr 26, 2023 • edited

cmsbuild commented Apr 26, 2023

cmsbuild commented Apr 27, 2023

perrotta commented Apr 27, 2023

simonepigazzini commented Apr 27, 2023

simonepigazzini commented Apr 27, 2023

cmsbuild commented Apr 27, 2023

RelVals

RelVals-INPUT

RelVals-NANO

AddOn Tests

cmsbuild commented Apr 29, 2023

AnnikaStein commented Apr 29, 2023

cmsbuild commented May 3, 2023

simonepigazzini commented May 3, 2023

AnnikaStein commented May 3, 2023

cmsbuild commented May 3, 2023

Comparison Summary

NANO Comparison Summary

AnnikaStein commented May 4, 2023

perrotta commented May 4, 2023

AlexDeMoor commented May 4, 2023

perrotta commented May 4, 2023

perrotta commented May 4, 2023

simonepigazzini commented May 5, 2023

clacaputo commented May 8, 2023

rappoccio commented May 9, 2023

AnnikaStein commented Apr 26, 2023 •

edited

cmsbuild commented Apr 26, 2023 •

edited