New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
removed unnecessary mutables from CondFormats/L1TObjects #4160
removed unnecessary mutables from CondFormats/L1TObjects #4160
Conversation
A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X. removed unnecessary mutables from CondFormats/L1TObjects It involves the following packages: CondFormats/L1TObjects @apfeiffer1, @nclopezo, @cmsbuild, @diguida, @rcastello, @ggovi, @Degano, @mulhearn can you please review it and eventually sign? Thanks. |
+1 |
Trivial. Bypassing various approvals. @davidlange6 |
+1 |
1 similar comment
+1 |
This isn't needed due to 4264 which deletes the unneeded format. |
I think if this gets merged I will have to rebase 4264, so please don't merge if that will make it... |
So indeed this does not merge now that 4264 is integrated. @DrJones.... |
The mutables were being flagged by the static analyzer as thread safety issues. Turns out the mutables were not needed since no const member functions ever modified the values.
This has now been rebased on top of CMSSW_7_1_X |
Pull request #4160 was updated. @apfeiffer1, @nclopezo, @cmsbuild, @diguida, @rcastello, @ggovi, @Degano, @mulhearn can you please check and sign again. |
previously signed - and still trivial - so bypassing |
…atsL1TObjects removed unnecessary mutables from CondFormats/L1TObjects
The mutables were being flagged by the static analyzer as thread
safety issues. Turns out the mutables were not needed since no
const member functions ever modified the values.