Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed unnecessary mutables from CondFormats/L1TObjects #4160

Conversation

Dr15Jones
Copy link
Contributor

The mutables were being flagged by the static analyzer as thread
safety issues. Turns out the mutables were not needed since no
const member functions ever modified the values.

@cmsbuild
Copy link
Contributor

cmsbuild commented Jun 7, 2014

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_1_X.

removed unnecessary mutables from CondFormats/L1TObjects

It involves the following packages:

CondFormats/L1TObjects

@apfeiffer1, @nclopezo, @cmsbuild, @diguida, @rcastello, @ggovi, @Degano, @mulhearn can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@mulhearn
Copy link
Contributor

+1

@ktf
Copy link
Contributor

ktf commented Jun 12, 2014

Trivial. Bypassing various approvals. @davidlange6

@diguida
Copy link
Contributor

diguida commented Jun 12, 2014

+1

1 similar comment
@apfeiffer1
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@mulhearn
Copy link
Contributor

This isn't needed due to 4264 which deletes the unneeded format.

@mulhearn
Copy link
Contributor

I think if this gets merged I will have to rebase 4264, so please don't merge if that will make it...

@davidlange6
Copy link
Contributor

So indeed this does not merge now that 4264 is integrated. @DrJones....

The mutables were being flagged by the static analyzer as thread
safety issues. Turns out the mutables were not needed since no
const member functions ever modified the values.
@Dr15Jones
Copy link
Contributor Author

This has now been rebased on top of CMSSW_7_1_X

@cmsbuild
Copy link
Contributor

Pull request #4160 was updated. @apfeiffer1, @nclopezo, @cmsbuild, @diguida, @rcastello, @ggovi, @Degano, @mulhearn can you please check and sign again.

@davidlange6
Copy link
Contributor

previously signed - and still trivial - so bypassing

davidlange6 added a commit that referenced this pull request Jun 18, 2014
…atsL1TObjects

removed unnecessary mutables from CondFormats/L1TObjects
@davidlange6 davidlange6 merged commit 396633c into cms-sw:CMSSW_7_1_X Jun 18, 2014
@ktf ktf mentioned this pull request Jun 23, 2014
@Dr15Jones Dr15Jones deleted the removeUnneededMutableCondFormatsL1TObjects branch June 25, 2014 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants