Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12_4_X] Update run3 offline data GT for 2022ABCDE partial rereco #41612

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

(partial) Backport of #41609

This PR updates the run3 offline data GT:

  • Update the run3 offline data GT to include two fixes:

GT differences:

As described in this CMSTalk post this GT will be used in the partial 2022ABCDE rereco and, given that we might need another 12_4_X release for that (to include the HcalPFcuts threshold update), we can direcatly include the new GT in the new release.
FYI @jordan-martins @maeshima @malbouis

PR validation:

Code compiles - will use the bot to run the matrix tests

Backport:

(partial) Backport of #41609

@francescobrivio
Copy link
Contributor Author

backport of #41609

@cmsbuild
Copy link
Contributor

cmsbuild commented May 10, 2023

A new Pull Request was created by @francescobrivio for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/AlCa (alca)

@cmsbuild, @tvami, @saumyaphor4252, @francescobrivio can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @mmusich, @fabiocos, @tocheng this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

test parameters:

  • workflow = 1002.3

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2fabbf/32533/summary.html
COMMIT: 4a5d956
CMSSW: CMSSW_12_4_X_2023-05-09-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41612/32533/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 20 lines from the logs
  • Reco comparison results: 4 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3780957
  • DQMHistoTests: Total failures: 7
  • DQMHistoTests: Total nulls: 1
  • DQMHistoTests: Total successes: 3780927
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -0.004 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 312.0 ): -0.004 KiB MessageLogger/Warnings
  • Checked 216 log files, 168 edm output root files, 52 DQM output files
  • TriggerResults: no differences found

@tvami
Copy link
Contributor

tvami commented May 10, 2023

+alca

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8e4e5cf into cms-sw:CMSSW_12_4_X May 12, 2023
11 checks passed
@francescobrivio francescobrivio deleted the alca-update_data_run3_GTs_12_4_X branch June 9, 2023 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants