Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use HLT:@relval2022_postEE in re-reco MC RelVal using 'postEE' GT [12_4_X only] #41646

Merged

Conversation

missirol
Copy link
Contributor

PR description:

The MC wfs added in #41591 use the MC GT auto:phase1_2022_realistic_postEE. To be consistent with the HLT conditions in that GT, the HLT menu used in those wfs should be HLT:@relval2022_postEE, not HLT:@relval2022.

PR validation:

runTheMatrix.py -nel 14034.0 -w upgrade

If this PR is a backport, please specify the original PR and why you need to backport that PR. If this PR will be backported, please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @missirol (Marino Missiroli) for CMSSW_12_4_X.

It involves the following packages:

  • Configuration/PyReleaseValidation (pdmv, upgrade)

@bbilin, @cmsbuild, @AdrianoDee, @srimanob, @kskovpen, @sunilUIET can you please review it and eventually sign? Thanks.
@makortel, @Martin-Grunewald, @fabiocos, @slomeo, @kpedro88 this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@missirol
Copy link
Contributor Author

test parameters:

  • relvals_opt = -w upgrade
  • workflows = 14034.0

@missirol
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-b65637/32583/summary.html
COMMIT: 4086f09
CMSSW: CMSSW_12_4_X_2023-05-09-2300/el8_amd64_gcc10
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/41646/32583/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 10 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 15 differences found in the comparisons
  • DQMHistoTests: Total files compared: 52
  • DQMHistoTests: Total histograms compared: 3926815
  • DQMHistoTests: Total failures: 1267
  • DQMHistoTests: Total nulls: 12
  • DQMHistoTests: Total successes: 3925514
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -2977.998 KiB( 51 files compared)
  • DQMHistoSizes: changed ( 14034.0 ): -1459.617 KiB HLT/JME
  • DQMHistoSizes: changed ( 14034.0 ): -751.112 KiB HLT/EGM
  • DQMHistoSizes: changed ( 14034.0 ): -279.291 KiB HLT/EXO
  • DQMHistoSizes: changed ( 14034.0 ): -210.264 KiB HLT/HLTEgammaValidation
  • DQMHistoSizes: changed ( 14034.0 ): -163.386 KiB HLT/TAU
  • DQMHistoSizes: changed ( 14034.0 ): -122.679 KiB HLT/Muon
  • DQMHistoSizes: changed ( 14034.0 ): 96.413 KiB HLT/Filters
  • DQMHistoSizes: changed ( 14034.0 ): -34.929 KiB HLT/Objects
  • DQMHistoSizes: changed ( 14034.0 ): -30.352 KiB HLT/HLTJETMET
  • DQMHistoSizes: changed ( 14034.0 ): -29.375 KiB HLT/SUSY
  • DQMHistoSizes: changed ( 14034.0 ): ...
  • Checked 217 log files, 172 edm output root files, 52 DQM output files
  • TriggerResults: found differences in 1 / 51 workflows

@sunilUIET
Copy link
Contributor

+pdmv

@missirol
Copy link
Contributor Author

missirol commented May 15, 2023

@cms-sw/upgrade-l2

Could you please review this PR ?

@srimanob
Copy link
Contributor

+Upgrade

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_12_4_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will now be reviewed by the release team before it's merged. @perrotta, @dpiparo, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 946b98d into cms-sw:CMSSW_12_4_X May 15, 2023
11 checks passed
@missirol missirol deleted the devel_fixHLTIn2022ReRecoRelVal branch June 15, 2023 05:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants