Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_1_X] Add VertexSmearing scenario for 2023 MC #41720

Merged

Conversation

francescobrivio
Copy link
Contributor

PR description:

Backport of #41719

This PR adds the realistic VertexSmearing scenario to be used for the 2023 MC production:

  • Realistic25ns13p6TeVEarly2023Collision

Input parameters:

  • The BeamSpot is extracted from Run2023C averaging Fills 8728-8750 (thanks @dzuolo!)
  • The BPIX barycenter is taken from this twiki

IMPORTANT NOTE:
Even though at the moment this scenario is not used anywhere in the release, we need this merged asap in order to produce relvals with this smearing and fit the BeamSpot to be added to the GTs for 2023 MC.

PR validation:

Code compiles (at the moment this scenario is not used anywhere in the release)

Backport:

Backport of #41719

FYI @mmusich @cms-sw/alca-l2

@francescobrivio
Copy link
Contributor Author

backport of #41719

@cmsbuild
Copy link
Contributor

cmsbuild commented May 18, 2023

A new Pull Request was created by @francescobrivio for CMSSW_13_1_X.

It involves the following packages:

  • Configuration/StandardSequences (operations)
  • IOMC/EventVertexGenerators (simulation)

@perrotta, @rappoccio, @civanch, @mdhildreth, @cmsbuild, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@fabiocos, @VourMa, @makortel, @felicepantaleo, @GiacomoSguazzoni, @JanFSchulte, @rovere, @VinInn, @Martin-Grunewald, @missirol, @grzanka, @mmusich, @sameasy, @mtosi, @dgulhan, @slomeo this is something you requested to watch as well.
@perrotta, @dpiparo, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@francescobrivio
Copy link
Contributor Author

urgent

  • as mentioned in the PR description we need this to generate RelVals and fit the BeamSpot to be added to the GTs

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

  • even though nothing is really testing the new scenario

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-504ff9/32710/summary.html
COMMIT: 0afd55e
CMSSW: CMSSW_13_1_X_2023-05-17-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41720/32710/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 1002.41002.4_RunDoubleMuon2022B/step2_RunDoubleMuon2022B.log
  • 21034.11421034.114_TTbar_14TeV+2026D88PU_OTInefficiency10PC/step2_TTbar_14TeV+2026D88PU_OTInefficiency10PC.log
  • 21034.9921034.99_TTbar_14TeV+2026D88PU_PMXS1S2/step2_TTbar_14TeV+2026D88PU_PMXS1S2.log

Comparison Summary

Summary:

  • You potentially removed 31 lines from the logs
  • Reco comparison results: 5 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222422
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3222394
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@francescobrivio
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-504ff9/32716/summary.html
COMMIT: 0afd55e
CMSSW: CMSSW_13_1_X_2023-05-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/41720/32716/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 7 lines to the logs
  • Reco comparison results: 11 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3222422
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3222391
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented May 20, 2023

+1

@perrotta
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_1_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_2_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit f90f373 into cms-sw:CMSSW_13_1_X May 21, 2023
10 checks passed
@francescobrivio francescobrivio deleted the alca-2023_MC_beamspot_13_1_X branch June 9, 2023 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants