Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to account for additional CPU time per event #4213

Merged
merged 1 commit into from Jun 13, 2014

Conversation

Dr15Jones
Copy link
Contributor

Created a new base class for the Timing Service so other modules can report additional CPU time spent by a job external to cmsRun.

Created a new base class for the Timing Service so other modules can report additional CPU time spent by a job external to cmsRun.
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @Dr15Jones (Chris Jones) for CMSSW_7_2_X.

Add ability to account for additional CPU time per event

It involves the following packages:

FWCore/Services
FWCore/Utilities

@cmsbuild, @Degano, @Dr15Jones, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
@wddgit, @wmtan this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@Dr15Jones
Copy link
Contributor Author

@bendavid Josh, here is the modification to allow extra CPU time to be accounted for.

@Dr15Jones
Copy link
Contributor Author

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@bendavid
Copy link
Contributor

Thanks,
Are there some instructions for the bits we need to add to ExternalLHEProducer to make use of this?

@Dr15Jones
Copy link
Contributor Author

This works like any other service:

#include "FWCore/Utilities/interface/TimingServiceBase.h"
#include "FWCore/ServiceRegistry/interface/Service.h"
...
edm::Service<TimingServiceBase> timing;
timing->addToCPUTime(1.0);

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 13, 2014
Add ability to account for additional CPU time per event.
@ktf ktf merged commit 825bfd2 into cms-sw:CMSSW_7_2_X Jun 13, 2014
@Dr15Jones Dr15Jones deleted the createdTimingServiceBase branch June 25, 2014 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants