Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastTimerService: avoid race condition across different threads when updating summary information #4257

Merged

Conversation

fwyzard
Copy link
Contributor

@fwyzard fwyzard commented Jun 15, 2014

No description provided.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @fwyzard (Andrea Bocci) for CMSSW_7_1_X.

FastTimerService: avoid race condition across different threads when updating summary information

It involves the following packages:

HLTrigger/Timer

@perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 15, 2014

This should fix a race condition where different threads would update the summary information at the same time, possibly resulting in a corrupted summary.

Helgrind does not spot any other problems...

@cmsbuild
Copy link
Contributor

@fwyzard
Copy link
Contributor Author

fwyzard commented Jun 16, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

davidlange6 added a commit that referenced this pull request Jun 16, 2014
FastTimerService: avoid race condition across different threads when updating summary information
@davidlange6 davidlange6 merged commit 2c8a7d4 into cms-sw:CMSSW_7_1_X Jun 16, 2014
@fwyzard fwyzard deleted the FastTimerService_summary_mutex branch June 21, 2014 18:55
@ktf ktf mentioned this pull request Jun 23, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants