Trivial Fix for VertexFromTrackProducer #4263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @battibass (Carlo Battilana) for CMSSW_7_1_X. Trivial Fix for VertexFromTrackProducer It involves the following packages: RecoTauTag/HLTProducers @perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please review it and eventually sign? Thanks. |
|
+1 |
1 similar comment
davidlange6
added a commit
that referenced
this pull request
Jun 16, 2014
Trivial Fix for VertexFromTrackProducer
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a trivial fix for a bug introduced during the "consumes migration" of VertexFromTrackProducer.
Basically the bug was affecting the rate reduction power of isolation @ HLT.
Tracks from edm:Vievreco::RecoCandidate > were not properly accessed, preventing from correct generation of vertexes from RecoCandidate tracks.
The net effect in rate reduction for a sample (IsoMu24) path can be summarized as:
Release details / Relative Rate w.r.t. non Iso Path
CMSSW_7_1_0_pre5 (last pre release before the bug was introduced) / relative rate: ~37%
CMSSW_7_1_0_pre9 (before bugfix) / relative rate: ~45%
CMSSW_7_1_0_pre9 (after bugfix) / relative rate: ~37%
@mbluj