Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

check for empty collection in SiStripApproximateClusterCollection [13_2_X] #42776

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

kpedro88
Copy link
Contributor

backport of #42752

needed for datataking

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 13, 2023

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_13_2_X.

It involves the following packages:

  • DataFormats/SiStripCluster (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@echabert, @robervalwalsh, @rovere, @VinInn, @missirol, @alesaggio, @mmusich, @threus, @jlidrych this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test workflow 140.58, 140.6, 160.2

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-91cf9f/34734/summary.html
COMMIT: f3bd210
CMSSW: CMSSW_13_2_X_2023-09-12-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42776/34734/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 9 lines from the logs
  • Reco comparison results: 2955 differences found in the comparisons
  • DQMHistoTests: Total files compared: 51
  • DQMHistoTests: Total histograms compared: 3404483
  • DQMHistoTests: Total failures: 4686
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3399775
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 50 files compared)
  • Checked 219 log files, 167 edm output root files, 51 DQM output files
  • TriggerResults: found differences in 1 / 49 workflows

@mmusich
Copy link
Contributor

mmusich commented Sep 13, 2023

type bug-fix

@mmusich
Copy link
Contributor

mmusich commented Sep 13, 2023

urgent

@mandrenguyen
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit ae532ef into cms-sw:CMSSW_13_2_X Sep 13, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants