Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13_2_X] Update autoSkim with 2023 PbPb skims #42784

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

youyingli
Copy link
Contributor

backport of #42754

@mandrenguyen

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 13, 2023

A new Pull Request was created by @youyingli (You-Ying Li) for CMSSW_13_2_X.

It involves the following packages:

  • Configuration/Skimming (pdmv)

@cmsbuild, @bbilin, @miquork, @sunilUIET, @AdrianoDee can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @fabiocos this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@youyingli
Copy link
Contributor Author

@sunilUIET @mandrenguyen could you please trigger it and sign it if passing?

@cmsbuild
Copy link
Contributor

Pull request #42784 was updated. @cmsbuild, @AdrianoDee, @miquork, @sunilUIET can you please check and sign again.

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f22f9c/34775/summary.html
COMMIT: 101fe09
CMSSW: CMSSW_13_2_X_2023-09-14-2300/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42784/34775/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 13434.013434.0_TTbar_14TeV+2021FSPU/step2_TTbar_14TeV+2021FSPU.log
  • 14234.014234.0_TTbar_14TeV+2023FSPU/step2_TTbar_14TeV+2023FSPU.log
  • 25034.11425034.114_TTbar_14TeV+2026D98PU_OTInefficiency10PC/step2_TTbar_14TeV+2026D98PU_OTInefficiency10PC.log

Comparison Summary

Summary:

  • You potentially removed 3 lines from the logs
  • Reco comparison results: 2 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198168
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198146
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@youyingli
Copy link
Contributor Author

Need to be retriggered again.

@sunilUIET
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f22f9c/34780/summary.html
COMMIT: 101fe09
CMSSW: CMSSW_13_2_X_2023-09-15-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/42784/34780/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 6 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198168
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198146
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@youyingli
Copy link
Contributor Author

@sunilUIET please sign it. Thanks!

@sunilUIET
Copy link
Contributor

+pdmv

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_13_3_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f181cd2 into cms-sw:CMSSW_13_2_X Sep 18, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants