Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in Higgs HLT validation DQM for multithreading #4281

Merged
merged 3 commits into from Jun 25, 2014

Conversation

HuguesBrun
Copy link
Contributor

This PR is a fix in the Higgs HLT validation DQM to permit it to work multithreaded.
The fix consists in filling the label of the efficiency summary when creating the histogram and not in the fly as before.

Two other small changes haves been done:

  • the summary and PU histograms are created directly from a ebooker method and not using a intermediate TH1F
  • the summary of efficiency plots is now created using the DQM generic client and not anymore using the HLTHiggsHarvesting class, which is removed.

The content of the plots is not changed by this PR

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @HuguesBrun (Hugues BRUN) for CMSSW_7_1_X.

Fix in Higgs HLT validation DQM for multithreading

It involves the following packages:

HLTriggerOffline/Higgs

@ojeda, @danduggan, @rovere, @cmsbuild, @nclopezo, @deguio, @Degano can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@deguio
Copy link
Contributor

deguio commented Jun 17, 2014

@HuguesBrun could you submit this PR to 72X first?
thanks,
F.

@HuguesBrun
Copy link
Contributor Author

Hello @deguio ,

I just send the new PR, it is PR#4299
Thank you,
Hugues

@deguio
Copy link
Contributor

deguio commented Jun 22, 2014

+1
already tested in 72X #4299

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_1_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@ktf ktf modified the milestones: Next CMSSW_7_1_X, CMSSW_7_1_0 Jun 23, 2014
davidlange6 added a commit that referenced this pull request Jun 25, 2014
Fix in Higgs HLT validation DQM for multithreading
@davidlange6 davidlange6 merged commit 3b53b41 into cms-sw:CMSSW_7_1_X Jun 25, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants