Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove unused vector in HiPuRhoProducer [13_2_X] #42811

Merged
merged 1 commit into from
Sep 18, 2023

Conversation

kpedro88
Copy link
Contributor

backport of #42810

@cmsbuild
Copy link
Contributor

cmsbuild commented Sep 18, 2023

A new Pull Request was created by @kpedro88 (Kevin Pedro) for CMSSW_13_2_X.

It involves the following packages:

  • RecoHI/HiJetAlgos (reconstruction)

@cmsbuild, @jfernan2, @mandrenguyen can you please review it and eventually sign? Thanks.
@yslai, @jazzitup, @missirol, @yenjie, @kurtejung, @mandrenguyen, @dgulhan, @yetkinyilmaz this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@kpedro88
Copy link
Contributor Author

please test

@cmsbuild
Copy link
Contributor

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-451e5b/34799/summary.html
COMMIT: 5576f08
CMSSW: CMSSW_13_2_X_2023-09-18-1100/el8_amd64_gcc11
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/42811/34799/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

The relvals timed out after 4 hours.

Comparison Summary

Summary:

  • You potentially removed 18 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3198168
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3198146
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 207 log files, 159 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@rappoccio
Copy link
Contributor

+1

  • Test failures are temporary timeouts. Main branch passes. We have to unfortunately move quickly to get this into datataking. If there are failures in 13_2_X release, we will remake it.

@rappoccio
Copy link
Contributor

merge

@cmsbuild cmsbuild merged commit 990f79f into cms-sw:CMSSW_13_2_X Sep 18, 2023
9 of 10 checks passed
@jfernan2
Copy link
Contributor

+1
for the records

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_13_2_X IBs (but tests are reportedly failing) and once validation in the development release cycle CMSSW_13_3_X is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants