70X met uncertainty tool fixes

[schoef]

Fixed several issues regarding the MET uncertainty tool in PAT

[cmsbuild]

A new Pull Request was created by @schoef for CMSSW_7_0_X.

70X met uncertainty tool fixes

It involves the following packages:

JetMETCorrections/Type1MET
PhysicsTools/PatUtils

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
@TaiSakuma, @nhanvtran this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[cmsbuild]

-1

Tested at: d950177
I ran the usual tests and I found errors in the following unit tests:

---> test runtestPhysicsToolsPatAlgos had ERRORS

you can see the results of the tests here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4301/203/summary.html

[cmsbuild]

Comparison is ready
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4301/203/summary.html

[monttj]

@schoef and @TaiSakuma - trying to understand the changes. Isn't this PR in conflict with this #4045?

[schoef]

Yes it is.

Tai, I think you, Matthieu and I should chat.
Matthieu and I are trying to get in several changes in 70X/71X/72X.

On Mon, Jun 30, 2014 at 11:53 PM, Tae Jeong Kim notifications@github.com
wrote:

@schoef https://github.com/schoef and @TaiSakuma
https://github.com/TaiSakuma - trying to understand the changes. Isn't
this PR in conflict with this #4045
#4045?

—
Reply to this email directly or view it on GitHub
#4301 (comment).

[TaiSakuma]

@schoef, sure we can chat.

This PR confilicts with the commit TaiSakuma@9dce9b2.

If we want to make the same change for 70X/71X/72X, you can revert this commit.

I can do the refactoring later after you are done with your change.

[ghost]

ping
What's the status of this PR?

[schoef]

Hi,
the failure of the PR triggered some discussion.
I think we need a little more time to discuss amongst ourselves.
-r

On Mon, Jul 14, 2014 at 10:35 AM, Alessandro Degano <
notifications@github.com> wrote:

ping
What's the status of this PR?

—
Reply to this email directly or view it on GitHub
#4301 (comment).

[monttj]

+1
It has been delayed due to possible conflict with 72X.
But now it is understood that lots of new features will only appear in 72X.
And among MET developers in AT will have a discussion near future for this.

[mmarionncern]

All pat MET names have been changed and updated in the default pat configuration and in the miniAOD tool.

[cmsbuild]

Pull request #4301 was updated. @nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please check and sign again.

[cmsbuild]

+1
Tested at: c0a8385
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-4301/239/summary.html

[monttj]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

[slava77]

@schoef
In case you haven't seen, this PR was reverted by #5071.
So, we will need to have a new iteration to integrate it back with appropriate corrections. (a new PR will be needed)

[slava77]

I;m guessing these are the errors
https://cmssdt.cern.ch/SDT/cgi-bin/buildlogs/slc6_amd64_gcc481/CMSSW_7_0_X_2014-08-27-0200/JetMETCorrections/Modules