pat::Muon best track embedding fix (7.0.X)

[gpetruc]

1. properly initialize embeddedTunePMuonBestTrack_ and embeddedTunePMuonBestTrack_
2. make the getter work also on existing 7_0_6 files (the bool was wrong, but the vector size was correct)
   note: it doesn't need recompilation of any dependency, but it would be good to have this in a 7.0.X patch

@arizzi

[cmsbuild]

A new Pull Request was created by @gpetruc (Giovanni Petrucciani) for CMSSW_7_0_X.

pat::Muon best track embedding fix (7.0.X)

It involves the following packages:

DataFormats/PatCandidates

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

[ghost]

Hi, this PR cannot be merged. Can you please rebase?

[gpetruc]

Hi @Degano,

This PR is a single commit on top of the CMSSW_7_0_6 tag ( 572426e ) which as of now seems to be identical to the CMSSW_7_0_X branch, so I can't understand how it can fail merging, nor on top of what I should rebase it.

Giovanni

[monttj]

I am having this message when I tried to merge to CMSSW_7_0_X_2014-06-25-1400.

fatal: Couldn't find remote ref refs/pull/4359/head
Unexpected end of command stream

[arizzi]

perhaps you can try to cherry-pick the single commit?

On Thu, Jun 26, 2014 at 12:13 AM, Tae Jeong Kim notifications@github.com
wrote:

I am having this message when I tried to merge to
CMSSW_7_0_X_2014-06-25-1400.

fatal: Couldn't find remote ref refs/pull/4359/head
Unexpected end of command stream

—
Reply to this email directly or view it on GitHub
#4359 (comment).

[monttj]

It's strange. It does not work unless I misused "cherry-pick". I have no idea what that (below) means.

CMSSW_7_0_X_2014-06-25-1400/src > git cherry-pick c352c9a
fatal: bad revision 'c352c9a'

[arizzi]

can you try to merge from giovanni's github directly instead of the PR
number?

[monttj]

+1
It is mergeable from his github. Compiles OK. But how do we go with this technical conflicts?

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes or unless it breaks tests. @nclopezo, @ktf can you please take care of it?

[Dr15Jones]

The problem using the pull request directly has happened to other pull requests. The problem being worked on by the github team.

[arizzi]

@Degano @ktf can you guys meanwhile merge it from the original branch of giovanni? This is a needed bug-fix for miniAOD

[nclopezo]

Hi all,

I did a PR here:
#4446
let me know if this one is ok.

[arizzi]

seems ok