Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GenFilter for selecting events with GenPhotons backport to CMSSW_10_6_X #43593

Merged
merged 9 commits into from
Jan 22, 2024

Conversation

michele-mormile
Copy link
Contributor

@michele-mormile michele-mormile commented Dec 18, 2023

PR description:
I am adding a GenFilter whose use is to select events with at least 1 GenPhoton after Parton Showering with Pythia. This is needed to produce NLO samples enriched in photons, as for tW + photons from decay (cfr. https://indico.cern.ch/event/1293201/contributions/5434786/attachments/2659639/4606878/twa_sample_generation.pdf ;
https://its.cern.ch/jira/projects/CMSTOPMCREQ/issues/CMSTOPMCREQ-33?filter=allopenissues&orderby=cf%5B14808%5D+ASC%2C+priority+DESC%2C+updated+DESC)

PR validation:
I have tested that adding the GenFilter to the generation workflow does obtain the expected result of only selecting events with GenPhotons.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
I would like this PR to be backported to CMSSW_10_6 as it needs to be used for generating UL Run 2 samples
It is a backport of #42725

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @michele-mormile (Michele Mormile) for CMSSW_10_6_X.

It involves the following packages:

  • GeneratorInterface/GenFilters (generators)

@SiewYan, @GurpreetSinghChahal, @alberto-sanchez, @menglu21, @mkirsano, @cmsbuild, @bbilin can you please review it and eventually sign? Thanks.
@alberto-sanchez, @mkirsano this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Dec 18, 2023

cms-bot internal usage

@menglu21
Copy link
Contributor

@cmsbuild please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6ff294/36561/summary.html
COMMIT: b178c16
CMSSW: CMSSW_10_6_X_2023-12-17-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43593/36561/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 5 lines to the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 35
  • DQMHistoTests: Total histograms compared: 3215686
  • DQMHistoTests: Total failures: 1
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3215351
  • DQMHistoTests: Total skipped: 334
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
  • Checked 144 log files, 103 edm output root files, 35 DQM output files
  • TriggerResults: no differences found

@menglu21
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_0_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 2d6c5f6 into cms-sw:CMSSW_10_6_X Jan 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants