Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DQM/Integration package added back to CMSSW #4363

Merged
merged 3 commits into from Jun 26, 2014

Conversation

deguio
Copy link
Contributor

@deguio deguio commented Jun 23, 2014

all the added files are only used in the online. they don't affect the offline workflows. needed in 71X for the July GR. will be automatically forward ported to 72X.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @deguio for CMSSW_7_1_X.

DQM/Integration package added back to CMSSW

It involves the following packages:

DQM/Integration

The following packages do not have a category, yet:

DQM/Integration

@cmsbuild, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ktf
Copy link
Contributor

ktf commented Jun 24, 2014

Do you really need this kind of layout? The whole script directory will be copied in path...

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

@danduggan
Copy link
Contributor

It's not clear what we could remove right now for this July GR. We can trim down once we have everything running stably as a whole system, but many of these files correspond to services/scripts/configurations that are specific to online functionalities we either need right away or anticipate needing in the short term, so re-doing the layout would make most sense once we can make a more final call on these files.

@@ -0,0 +1,124 @@
import FWCore.ParameterSet.Config as cms
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why the strange filename?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was used as a rollback version to the fu_pp.py configuration in the same directory. However now the difference with fu_pp.py is only in the file list, so it could be removed.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds like it would be best to remove (maybe also the cvs setup files with passwords?)

On Jun 26, 2014, at 7:28 AM, "danduggan" <notifications@github.commailto:notifications@github.com> wrote:

In DQM/Integration/SMPlayback/cfg/~fu_pp.py:

@@ -0,0 +1,124 @@
+import FWCore.ParameterSet.Config as cms

This was used as a rollback version to the fu_pp.py configuration in the same directory. However now the difference with fu_pp.py is only in the file list, so it could be removed.


Reply to this email directly or view it on GitHubhttps://github.com//pull/4363/files#r14225803.

@deguio
Copy link
Contributor Author

deguio commented Jun 26, 2014

+1
hello @davidlange6 @ktf
I forgot to mention this PR in my summary email in HN. do you confirm that this can go in 711?
thanks and sorry about that,
F.

@deguio
Copy link
Contributor Author

deguio commented Jun 26, 2014

this new package should to be assigned to DQM

@cmsbuild
Copy link
Contributor

Pull request #4363 was updated. @cmsbuild, @Degano, @ktf, @nclopezo can you please check and sign again.

@davidlange6
Copy link
Contributor

merging - but perhaps we can also get rid of the csh version of the cvs setup as as followup PR..

davidlange6 added a commit that referenced this pull request Jun 26, 2014
DQM/Integration package added back to CMSSW
@davidlange6 davidlange6 merged commit ee7292c into cms-sw:CMSSW_7_1_X Jun 26, 2014
@deguio
Copy link
Contributor Author

deguio commented Jun 26, 2014

thanks,
F.

@ktf ktf mentioned this pull request Jun 26, 2014
ktf added a commit to ktf/cmssw that referenced this pull request Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants