Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hgcal rechits adctogev #4367

Merged
merged 3 commits into from
Jun 27, 2014

Conversation

vandreev11
Copy link
Contributor

@pfs, @amagnan, @lgray HGCAL rechits energy conversion into GeV applying digi-step constants

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @vandreev11 for CMSSW_6_2_X_SLHC.

Hgcal rechits adctogev

It involves the following packages:

RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HGCalRecProducers
SimGeneral/MixingModule

The following packages do not have a category, yet:

RecoLocalCalo/HGCalRecAlgos
RecoLocalCalo/HGCalRecProducers

@civanch, @nclopezo, @mdhildreth, @cmsbuild, @Degano, @ktf can you please review it and eventually sign? Thanks.
@wmtan, @argiro this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@lgray
Copy link
Contributor

lgray commented Jun 24, 2014

@vandreev11 Sweet, I will try to get this integrated asap. Is the MIP corrected as a function of eta, or is everything converted to GeV assuming eta = infinity?

@vandreev11
Copy link
Contributor Author

@lgray, @pfs single factor mipInKeV per subdetector is applied

@amagnan
Copy link
Contributor

amagnan commented Jun 24, 2014

so just to be clear, I think this means it's calibrated back to "G4
GeV", but not to actual "particle GeV". For the latter, we would need
single electron/pion in ECAL/HCAL to extract 4 calibration factors: EM
in ECAL, EM in HCAL, HAD in ECAL, and HAD in HCAL, which is what Peter
is working on now. Correct ?
Cheers,
AM.

On 06/24/2014 12:02 PM, vandreev11 wrote:

@lgray https://github.com/lgray, @pfs https://github.com/pfs single
factor mipInKeV per subdetector is applied


Reply to this email directly or view it on GitHub
#4367 (comment).

####################################################
Dr. Anne-Marie Magnan
CMS


42-3-037, CERN Imperial College, HEP Dept.
CH-1210 Geneva The Blackett Laboratory
Prince Consort Road
London SW7 2AZ
(+41)(0)22 76 6 25 46
http://www.cern.ch http://www.imperial.ac.uk

####################################################
â à è é ê ë æ î ï ô ö ù û ü ç
####################################################

@vandreev11
Copy link
Contributor Author

yes, it is LocalReco individual rechit conversion from adc to GeV using MIP digi factors

@fratnikov
Copy link

@vandreev11 : Who is supposed to formally sign off this PR?

@vandreev11
Copy link
Contributor Author

@fratnikov : on HGCAL subdetector level consider it is signed off by submitter, me in this case
👍

@fratnikov
Copy link

merge
tested on single pions. Known problems in harvesting for HGCal configurations

cmsbuild added a commit that referenced this pull request Jun 27, 2014
@cmsbuild cmsbuild merged commit a26d086 into cms-sw:CMSSW_6_2_X_SLHC Jun 27, 2014
@lgray
Copy link
Contributor

lgray commented Jun 27, 2014

@vandreev11 @fratnikov Ok, I will submit a patch today to the PFlow stuff to account for this change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants