Adding EMTF++ Emulator for Phase-2 #43766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…E0 comments pending.
… longer needed in the emulator.
|
cms-bot internal usage |
This was referenced Jan 22, 2024
|
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43766/38487
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
|
Pull request #43766 was updated. @subirsarkar, @epalencia, @cmsbuild, @srimanob, @aloeliger can you please check and sign again. |
|
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-43766/39350
|
|
Pull request #43766 was updated. @subirsarkar, @aloeliger, @cmsbuild, @srimanob, @epalencia can you please check and sign again. |
|
Please test |
|
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-c86b74/37916/summary.html Comparison SummarySummary:
|
|
+l1 |
|
ping @cms-sw/upgrade-l2 |
|
+Upgrade |
cmsbuild
added
fully-signed
upgrade-approved
and removed
pending-signatures
upgrade-pending
labels
|
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
|
+1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description:
This PR is enormous. It was inevitable. It contains the latest version of the EMTF++ emulator. The emulator is used to study the Phase-2 upgrade of EMTF. Other projects are waiting to integrate the emulator into their code. This code was developed and tested in CMSSW 13.3.0pre3.
Note on GEM changes
Initially, the emulator was designed for CMSSW 12.5.0pre3 and updated to CMSSW 13.3.0pre3. In this version of CMSSW, the GEM group renamed the ME0 chambers to GE0. However, this was not propagated to the L1Trigger packages, resulting in a few errors. Thanks to Ian Watson, I integrated GE0 to the L1Trigger in CMSSW 13.3.0pre3. I had to use a version of his fix intended for CMSSW 12.5.0pre3 for it to work. I checked the latest releases of CMSSW, and these fixes still need to arrive. Here's a link to Ian's fork containing the fix: https://github.com/watson-ij/cmssw/tree/2023-07-ge0-for-l1t-1253p3/L1Trigger
Besides this, there weren't any other major issues when moving to CMSSW 13.3.0pre3.
PR validation:
This PR is a follow-up to the PR1184. The CMS L1T, offline software group, checked this PR. They've reviewed my changes and given me the green light to make a PR to the main CMSSW branch.