Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Castor enabled #4380

Merged
merged 1 commit into from Jun 25, 2014
Merged

Castor enabled #4380

merged 1 commit into from Jun 25, 2014

Conversation

civanch
Copy link
Contributor

@civanch civanch commented Jun 24, 2014

Castor enabled by default.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @civanch (Vladimir Ivantchenko) for CMSSW_7_2_X.

Castor enabled

It involves the following packages:

SimG4Core/Application

@cmsbuild, @civanch, @Degano, @mdhildreth, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

@civanch
Copy link
Contributor Author

civanch commented Jun 24, 2014

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@davidlange6
Copy link
Contributor

@civanch - I had the impression yesterday that we decided instead to enable via a customize function for the 1-2 samples that is interesting for castor. (?)

@civanch
Copy link
Contributor Author

civanch commented Jun 25, 2014

@davidlange6 - they need to do comparison with "what was before". One way to provide this comparison is to enable Castor by default in 7_2_0_pre2, so they will have MinBias sample similar to previous. After they will do their tests we switch off Castor again and define only few workflows where Castor will be enabled.

Alternative is to request a special GEN_SIM sample with 7_2_0_pre1 only for Castor, in that case this PR is not needed, my worry is that MinBias will be different in that case.

@davidlange6
Copy link
Contributor

what differences are you thinking can which can affect anyone (aside from the castor group of course)?

On Jun 25, 2014, at 12:14 PM, Vladimir Ivantchenko notifications@github.com
wrote:

@davidlange6 - they need to do comparison with "what was before". One way to provide this comparison is to enable Castor by default in 7_2_0_pre2, so they will have MinBias sample similar to previous. After they will do their tests we switch off Castor again and define only few workflows where Castor will be enabled.

Alternative is to request a special GEN_SIM sample with 7_2_0_pre1 only for Castor, in that case this PR is not needed, my worry is that MinBias will be different in that case.


Reply to this email directly or view it on GitHub.

@civanch
Copy link
Contributor Author

civanch commented Jun 25, 2014

if log file is not grow (main problem in past) - no effect, except a little performance penalty (few %) and ~50 M extra memory.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 25, 2014
@ktf ktf merged commit 3e21e23 into cms-sw:CMSSW_7_2_X Jun 25, 2014
@cmsbuild
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants