Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix plus filter update for missing hits #4391

Merged
merged 3 commits into from Jun 26, 2014

Conversation

matteosan1
Copy link
Contributor

Fixed a bug in if sentence to select gsf or kf tracks.
Added production of missinghits value map for GSF track based paths.

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @matteosan1 (Matteo Sani) for CMSSW_7_2_X.

bugfix plus filter update for missing hits

It involves the following packages:

HLTrigger/Egamma
RecoEgamma/EgammaHLTProducers

@perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please review it and eventually sign? Thanks.
@lgray this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.

iEvent.put(dEtaMapForEvent, "Deta" );
iEvent.put(dPhiMapForEvent, "Dphi" );
iEvent.put(oneOverESuperMinusOneOverPMapForEvent,"OneOESuperMinusOneOP");
iEvent.put(oneOverESeedMinusOneOverPMapForEvent,"OneOESeedMinusOneOP");
iEvent.put(missingHitsForEvent, "MissingHits");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This put-statement will lead to run-time errors as the corresponding produces-statement is
missing the the construcor of the module. Please fix (and make a run-time test).

@Martin-Grunewald
Copy link
Contributor

-1

Missing produces<...> statement for new product.

@cmsbuild
Copy link
Contributor

Pull request #4391 was updated. @perrotta, @cmsbuild, @nclopezo, @Martin-Grunewald, @fwyzard, @Degano can you please check and sign again.

@Martin-Grunewald
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes or unless it breaks tests.

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_2_X IBs unless changes (tests are also fine).

ktf added a commit that referenced this pull request Jun 26, 2014
Bugfix plus filter update for missing hits.
@ktf ktf merged commit 4cad53a into cms-sw:CMSSW_7_2_X Jun 26, 2014
davidlange6 added a commit that referenced this pull request Jul 15, 2014
Bugfix plus filter update for missing hits, backport of #4391 to 71X
@matteosan1 matteosan1 deleted the topic_missinghits branch May 28, 2015 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants