Backport changes in BaseMVAValueMapProducer to 10_6_X

[hqucms]

PR description:

This PR backports two changes in BaseMVAValueMapProducer that have already been in the master branch to 10_6_X to avoid crash on empty src. This should fix #43863.

PR validation:

Tested locally and it fixes the crash reported in #43863.

[cmsbuild]

A new Pull Request was created by @hqucms (Huilin Qu) for CMSSW_10_6_X.

It involves the following packages:

• PhysicsTools/PatAlgos (xpog, reconstruction)

@hqucms, @cmsbuild, @jfernan2, @mandrenguyen, @vlimant can you please review it and eventually sign? Thanks.
@seemasharmafnal, @AnnikaStein, @gpetruc, @AlexDeMoor, @gouskos, @gkasieczka, @JyothsnaKomaragiri, @azotz, @jdolen, @nhanvtran, @mariadalfonso, @Ming-Yan, @andrzejnovak, @mbluj, @schoef, @hatakeyamak, @rappoccio, @jdamgov, @ahinzmann, @mmarionncern, @Senphy, @emilbols, @demuller this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

cms-bot internal usage

[hqucms]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0679a/37395/summary.html
COMMIT: 69c6a6c
CMSSW: CMSSW_10_6_X_2024-02-11-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43947/37395/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 5 lines to the logs
• Reco comparison results: 2 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 2
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215350
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 144 log files, 103 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[hqucms]

please test workflow 135.14

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0679a/37401/summary.html
COMMIT: 69c6a6c
CMSSW: CMSSW_10_6_X_2024-02-11-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43947/37401/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 6 differences found in the comparisons
• DQMHistoTests: Total files compared: 36
• DQMHistoTests: Total histograms compared: 3260934
• DQMHistoTests: Total failures: 3
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3260597
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 35 files compared)
• Checked 148 log files, 106 edm output root files, 36 DQM output files
• TriggerResults: no differences found

[hqucms]

+1

[jfernan2]

@hqucms despite it is not the scope of this PR, could we please take the ocasion to clean the buildfile to avoid the clang warning given in: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0679a/37401/buildClang.log

***WARNING: Multiple usage of "PhysicsTools/PatUtils". Please cleanup "use" in "non-export" section of "src/PhysicsTools/PatAlgos/BuildFile".

There are two Use PatUtils in:

cmssw/PhysicsTools/PatAlgos/BuildFile.xml

Lines 18 to 21 in 69c6a6c

	<use name="PhysicsTools/PatUtils"/>
	<use name="PhysicsTools/Utilities"/>
	<use name="PhysicsTools/IsolationAlgos"/>
	<use name="PhysicsTools/PatUtils"/>

Thanks

[cmsbuild]

Pull request #43947 was updated. @mandrenguyen, @cmsbuild, @vlimant, @hqucms, @jfernan2 can you please check and sign again.

[hqucms]

@jfernan2 Done.

[hqucms]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f0679a/37417/summary.html
COMMIT: 95aca04
CMSSW: CMSSW_10_6_X_2024-02-11-0000/slc7_amd64_gcc700
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/43947/37417/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• No significant changes to the logs found
• Reco comparison results: 0 differences found in the comparisons
• DQMHistoTests: Total files compared: 35
• DQMHistoTests: Total histograms compared: 3215686
• DQMHistoTests: Total failures: 1
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3215351
• DQMHistoTests: Total skipped: 334
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 34 files compared)
• Checked 144 log files, 103 edm output root files, 35 DQM output files
• TriggerResults: no differences found

[sbein]

I have tested the PR and it looks like the FastSim refinement ran fine. Thank you @hqucms

[hqucms]

+1

[jfernan2]

+1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_10_6_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[srimanob]

@hqucms @sbein Could you please clarify the situation in releases used for 2022 (12_4) and 2023 (13_0)? Do we need this PR there, or it is already there. This is in case we will produce fastsim sample in those releases. Thx.

[hqucms]

@hqucms @sbein Could you please clarify the situation in releases used for 2022 (12_4) and 2023 (13_0)? Do we need this PR there, or it is already there. This is in case we will produce fastsim sample in those releases. Thx.

The fix for BaseMVAValueMapProducer itself was included since 12_1_X (#35698) so 2022 (12_4) and 2023 (13_0) is OK. I let @sbein comment on the fastsim specific part.

[antoniovilela]

+1