-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hcal Sim Constants v2 #4404
Hcal Sim Constants v2 #4404
Conversation
ianna
commented
Jun 26, 2014
- Use Vector for definition of sim constants
- Provide helpers to extract Vectors
A new Pull Request was created by @ianna for CMSSW_6_2_X_SLHC. Hcal Sim Constants v2 It involves the following packages: DetectorDescription/Core @civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks. |
@bsunanda - Please, use this PR instead of closed one. It turns out there was repetitive code which is now extracted as DDVectorGetter::get and DDVectorGetter::check and placed in DetectorDescription/Core Thanks, Yana |
+1 |
merge |