Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hcal Sim Constants v2 #4404

Merged
merged 7 commits into from
Jun 27, 2014
Merged

Conversation

ianna
Copy link
Contributor

@ianna ianna commented Jun 26, 2014

  • Use Vector for definition of sim constants
  • Provide helpers to extract Vectors

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @ianna for CMSSW_6_2_X_SLHC.

Hcal Sim Constants v2

It involves the following packages:

DetectorDescription/Core
Geometry/HcalCommonData
SimG4CMS/Calo

@civanch, @Dr15Jones, @ianna, @mdhildreth, @cmsbuild, @nclopezo, @Degano, @ktf can you please review it and eventually sign? Thanks.
@ghellwig this is something you requested to watch as well.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@ianna
Copy link
Contributor Author

ianna commented Jun 26, 2014

@bsunanda - Please, use this PR instead of closed one. It turns out there was repetitive code which is now extracted as DDVectorGetter::get and DDVectorGetter::check and placed in DetectorDescription/Core

Thanks,

Yana

@ianna
Copy link
Contributor Author

ianna commented Jun 26, 2014

+1

@fratnikov
Copy link

merge
tested on single pions. Known problems in harvesting for HGCal configurations

cmsbuild added a commit that referenced this pull request Jun 27, 2014
@cmsbuild cmsbuild merged commit a5d9758 into cms-sw:CMSSW_6_2_X_SLHC Jun 27, 2014
@ianna ianna deleted the hcal-sim-constants-v2 branch October 26, 2015 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants