Dictionaries needed for ROOT 6 #4412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A new Pull Request was created by @wmtan for CMSSW_7_2_ROOT6_X. Dictionaries needed for ROOT 6 It involves the following packages: CondCore/ORA @ggovi, @cmsbuild, @apfeiffer1, @Degano, @nclopezo can you please review it and eventually sign? Thanks. |
davidlt
added a commit
that referenced
this pull request
Jun 26, 2014
Dictionaries needed for ROOT 6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In ROOT6, dictionaries are needed for classes ora::Reference and ora::NamedReference, even though these classes are not persisted. The absence of these dictionaries causes step 4 of relval test 1001 to fail.
This pull request adds these dictionaries to CondCore/ORA. Note that these dictionaries were also needed in ROOT 5, but only for the CondCore/ORA unit tests. Since these dictionaries will now be in CondCore/ORA itself, they no longer are needed in CondCore/ORA/test, as these would be duplicate definitions.
Note that this pull request is not sufficient to make step 4 of relval 1001 run successfully , because with this pull request, the test fails later for a different reason. Please merge promptly.