Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fixed getters to be able to read from miniAOD #4431

Merged
merged 1 commit into from Jul 1, 2014

Conversation

jpavel
Copy link
Contributor

@jpavel jpavel commented Jun 27, 2014

Bug fix for the pat::Tau accessor functions that use pfSpecific(). This function (rightly) returns cms::error, when ones tried to read from miniAOD because pfSpecific is not filled by patTauSlimmer. This bugfix introduces check for the existence of pfSpecific before accessing it.

Tau POG considers this bugfix critical for CSA14 - without it the analysis of taus in miniAOD will not be possible.

No change in physics output is expected.

@monicava, @veelken

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @jpavel (Pavel Jez) for CMSSW_7_0_X.

fixed getters to be able to read from miniAOD

It involves the following packages:

DataFormats/PatCandidates

@nclopezo, @vadler, @cmsbuild, @Degano, @monttj can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@nclopezo, @ktf you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@monttj
Copy link
Contributor

monttj commented Jun 30, 2014

+1
@jpavel Okay. So in miniAOD, (tau) PAT object is created from (tau) PAT object basically.
Did we have already 71X and 72X for this fix?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_7_0_X IBs unless changes (tests are also fine). @nclopezo, @ktf can you please take care of it?

@jpavel
Copy link
Contributor Author

jpavel commented Jul 1, 2014

@monttj Thanks for signing - there are no PR's for 71x and 72x yet, but as the change is trivial (one file), I will prepare them asap

@jpavel
Copy link
Contributor Author

jpavel commented Jul 1, 2014

So 2 new PR's created: #4466 (for 71x) and #4467 (for 72x)

@monttj
Copy link
Contributor

monttj commented Jul 1, 2014

Hi Pavel, thank you!

davidlange6 added a commit that referenced this pull request Jul 1, 2014
fixed getters to be able to read from miniAOD
@davidlange6 davidlange6 merged commit 5b09851 into cms-sw:CMSSW_7_0_X Jul 1, 2014
@jpavel jpavel deleted the 70x_taus_miniAODaccess branch July 1, 2014 21:20
ktf added a commit to ktf/cmssw that referenced this pull request Jul 3, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants