Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add some pixel monitoring elements to per lumisection configuration #44343

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

LukaLambrecht
Copy link
Contributor

PR description:

This pull requests updates the per-lumisection DQMIO configuration file, to add 12 monitoring elements from the pixel tracker to per-lumisection saving (instead of default per-run) in the DQMIO file format.

The names of the newly added monitoring elements are:
PixelPhase1/Phase1_MechanicalView/PXBarrel/digi_occupancy_per_SignedModuleCoord_per_SignedLadderCoord_PXLayer_[1,2,3,4]
PixelPhase1/Phase1_MechanicalView/PXForward/digi_occupancy_per_SignedDiskCoord_per_SignedBladePanelCoord_PXRing_[1,2]
PixelPhase1/Phase1_MechanicalView/PXBarrel/clusters_per_SignedModuleCoord_per_SignedLadderCoord_PXLayer_[1,2,3,4]
PixelPhase1/Phase1_MechanicalView/PXForward/clusters_per_SignedDiskCoord_per_SignedBladePanelCoord_PXRing_[1,2]

PR validation:

This PR was validated by running the DQMIO production from RAW locally, and the output is as expected. We also checked the impact on the size of the produced DQMIO files, but the impact of adding these monitoring elements is negligible.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport to 14_0_X of PR 44339.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

A new Pull Request was created by @LukaLambrecht for CMSSW_14_0_X.

It involves the following packages:

  • DQMServices/Core (dqm)

@cmsbuild, @antoniovagnerini, @syuvivida, @nothingface0, @tjavaid, @rvenditti can you please review it and eventually sign? Thanks.
@barvic this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 7, 2024

cms-bot internal usage

@perrotta
Copy link
Contributor

backport of #44339.

@mmusich
Copy link
Contributor

mmusich commented Mar 19, 2024

backport of #44339

@mmusich
Copy link
Contributor

mmusich commented Mar 19, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-35cc7f/38248/summary.html
COMMIT: c6b37dc
CMSSW: CMSSW_14_0_X_2024-03-18-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44343/38248/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • Reco comparison results: 42 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346212
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346187
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Mar 25, 2024

+1

  • @LukaLambrecht , could you please edit the title of the backport PR labeling "[14.0.X]"?

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 3ec5794 into cms-sw:CMSSW_14_0_X Mar 27, 2024
10 checks passed
@LukaLambrecht LukaLambrecht deleted the add-pixel-mes-backport branch April 2, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants