Add reco::Muon displacedMuons to offline validation sequences #44353

24LopezR · 2024-03-08T09:10:06Z

PR description:

In this PR we add the code to include the reco::Muon displaced muon AOD collection to the Muon offline validation. An analyzer is added to Validation/RecoMuon/src, very similar to the one for standard muons. Also the necessary configuration files are added, and the sequences included in the global configuration.
Validation for standard muon collection is left unchanged.

See presentation on MUO POG General meeting: https://indico.cern.ch/event/1389920/#2-displaced-muon-in-the-valida

PR validation:

New offline DQM has been run on a real validation sample: workflow 12524.0 DisplacedSUSY with 5000 events.
The code runs smoothly and the new validation folder Muons/RecoDisplacedMuonV is in the DQM file with the correct plots. As an example, see Dxy plot of reco tracks for dSA [1] and dGl [2].

[1]

[2]

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

It is not necessary to backport this PR.

cmsbuild · 2024-03-08T09:10:37Z

cms-bot internal usage

cmsbuild · 2024-03-08T09:17:16Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44353/39391

This PR adds an extra 36KB to repository

cmsbuild · 2024-03-08T09:17:36Z

A new Pull Request was created by @24LopezR for master.

It involves the following packages:

Validation/RecoMuon (dqm)

@cmsbuild, @nothingface0, @syuvivida, @antoniovagnerini, @tjavaid, @rvenditti can you please review it and eventually sign? Thanks.
@JanFSchulte, @missirol, @CeliaFernandez, @jhgoh, @cericeci, @calderona, @HuguesBrun, @andrea21z, @abbiendi, @rociovilar, @Fedespring, @trocino this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

tjavaid · 2024-03-08T17:14:03Z

please test

cmsbuild · 2024-03-08T18:40:13Z

-1

Failed Tests: RelVals RelVals-INPUT AddOn
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-111b89/37999/summary.html
COMMIT: 334a36c
CMSSW: CMSSW_14_1_X_2024-03-08-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44353/37999/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals

135.4

----- Begin Fatal Exception 08-Mar-2024 18:34:05 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step'
   [2] Calling method for module RecoDisplacedMuonValidator/'recoDisplacedMuonVMuAssoc_tgt'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Muon
Looking for module label: displacedMuons
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

5.1

----- Begin Fatal Exception 08-Mar-2024 18:34:08 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step'
   [2] Calling method for module RecoDisplacedMuonValidator/'recoDisplacedMuonVMuAssoc_tgt'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Muon
Looking for module label: displacedMuons
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

13234.0

----- Begin Fatal Exception 08-Mar-2024 18:54:03 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 0
   [1] Running path 'validation_step'
   [2] Calling method for module RecoDisplacedMuonValidator/'recoDisplacedMuonVMuAssoc_tgt'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Muon
Looking for module label: displacedMuons
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

Expand to see more relval errors ...

RelVals-INPUT

13234.013234.0_TTbar_14TeV+2021FS/step2_TTbar_14TeV+2021FS.log
14034.014034.0_TTbar_14TeV+2023FS/step2_TTbar_14TeV+2023FS.log
13434.013434.0_TTbar_14TeV+2021FSPU/step2_TTbar_14TeV+2021FSPU.log

Expand to see more relval errors ...

14234.0

AddOn Tests

fastsim

----- Begin Fatal Exception 08-Mar-2024 18:35:42 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 2 stream: 2
   [1] Running path 'validation_step'
   [2] Calling method for module RecoDisplacedMuonValidator/'recoDisplacedMuonVMuAssoc_tgt'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Muon
Looking for module label: displacedMuons
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

fastsim1

----- Begin Fatal Exception 08-Mar-2024 18:35:41 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 4 stream: 2
   [1] Running path 'validation_step'
   [2] Calling method for module RecoDisplacedMuonValidator/'recoDisplacedMuonVMuAssoc_tgt'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Muon
Looking for module label: displacedMuons
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

fastsim2

----- Begin Fatal Exception 08-Mar-2024 18:35:41 CET-----------------------
An exception of category 'ProductNotFound' occurred while
   [0] Processing  Event run: 1 lumi: 1 event: 1 stream: 3
   [1] Running path 'validation_step'
   [2] Calling method for module RecoDisplacedMuonValidator/'recoDisplacedMuonVMuAssoc_tgt'
Exception Message:
Principal::getByToken: Found zero products matching all criteria
Looking for a container with elements of type: reco::Muon
Looking for module label: displacedMuons
Looking for productInstanceName: 

   Additional Info:
      [a] If you wish to continue processing events after a ProductNotFound exception,
add "TryToContinue = cms.untracked.vstring('ProductNotFound')" to the "options" PSet in the configuration.

----- End Fatal Exception -------------------------------------------------

24LopezR · 2024-03-11T14:30:06Z

Apparently, I added the validation sequence to fastsim and this should not be there. I fixed it and rerun the tests and now they run OK.

cmsbuild · 2024-03-11T14:38:13Z

Pull request #44353 was updated. @nothingface0, @syuvivida, @cmsbuild, @tjavaid, @antoniovagnerini, @rvenditti can you please check and sign again.

tjavaid · 2024-03-12T14:58:46Z

please test

cmsbuild · 2024-03-12T21:16:04Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-111b89/38067/summary.html
COMMIT: 2785e6e
CMSSW: CMSSW_14_1_X_2024-03-12-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44353/38067/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially added 4 lines to the logs
Reco comparison results: 63 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297383
DQMHistoTests: Total failures: 1358
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3296005
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 29848.476 KiB( 47 files compared)
DQMHistoSizes: changed ( 10224.0,... ): 2132.034 KiB Muons/RecoDisplacedMuonV
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

tjavaid · 2024-03-27T14:03:08Z

please test

cmsbuild · 2024-03-27T16:49:19Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-111b89/38456/summary.html
COMMIT: 2785e6e
CMSSW: CMSSW_14_1_X_2024-03-26-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44353/38456/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

You potentially removed 105 lines from the logs
Reco comparison results: 46 differences found in the comparisons
DQMHistoTests: Total files compared: 48
DQMHistoTests: Total histograms compared: 3297857
DQMHistoTests: Total failures: 6
DQMHistoTests: Total nulls: 0
DQMHistoTests: Total successes: 3297831
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 29848.476 KiB( 47 files compared)
DQMHistoSizes: changed ( 10224.0,... ): 2132.034 KiB Muons/RecoDisplacedMuonV
Checked 202 log files, 165 edm output root files, 48 DQM output files
TriggerResults: no differences found

tjavaid · 2024-04-02T05:39:33Z

+1

cmsbuild · 2024-04-02T05:39:59Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

antoniovilela · 2024-04-02T14:15:32Z

+1

24LopezR added 7 commits December 14, 2023 17:20

Added displacedMuon sequences + small code change (testing)

59287bd

Add separate script (error)

124e897

Fixed displacedMuon sequences

c02acdf

Tune hists + Add postproc

341980f

Set Dxy and Dz hist limits

a52cd11

Wider binning in Dxy Dz and rename hists to original

68ca4b3

Code-format

334a36c

cmsbuild added this to the CMSSW_14_1_X milestone Mar 8, 2024

cmsbuild added dqm-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 8, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 8, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 8, 2024

cmsbuild added tests-rejected and removed tests-started labels Mar 8, 2024

Remove displaced validation from fastsim sequence

2785e6e

cmsbuild added tests-pending code-checks-pending and removed tests-rejected code-checks-approved labels Mar 11, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 11, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 12, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 12, 2024

cmsbuild added tests-started and removed tests-approved labels Mar 27, 2024

cmsbuild added tests-approved and removed tests-started labels Mar 27, 2024

cmsbuild added dqm-approved fully-signed and removed dqm-pending pending-signatures labels Apr 2, 2024

cmsbuild added orp-approved and removed orp-pending labels Apr 2, 2024

cmsbuild merged commit bbc919f into cms-sw:master Apr 2, 2024
11 checks passed

This was referenced Apr 2, 2024

Slight update to TensorFlowAOT interface. #44586

Merged

CalorimeterDefinitions: don't return -1 as uint32_t #44608

Merged

PFTau.cc: remove pessimizing move #44618

Merged

[Do not merge] Test all gcc13 changes together #44632

Closed

24LopezR mentioned this pull request Apr 8, 2024

Add reco::displacedMuons to offline validation (backport) #44657

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add reco::Muon displacedMuons to offline validation sequences #44353

Add reco::Muon displacedMuons to offline validation sequences #44353

24LopezR commented Mar 8, 2024

cmsbuild commented Mar 8, 2024 •

edited

cmsbuild commented Mar 8, 2024

cmsbuild commented Mar 8, 2024

tjavaid commented Mar 8, 2024

cmsbuild commented Mar 8, 2024

24LopezR commented Mar 11, 2024

cmsbuild commented Mar 11, 2024

tjavaid commented Mar 12, 2024

cmsbuild commented Mar 12, 2024

tjavaid commented Mar 27, 2024

cmsbuild commented Mar 27, 2024

tjavaid commented Apr 2, 2024

cmsbuild commented Apr 2, 2024

antoniovilela commented Apr 2, 2024

Add reco::Muon displacedMuons to offline validation sequences #44353

Add reco::Muon displacedMuons to offline validation sequences #44353

Conversation

24LopezR commented Mar 8, 2024

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Mar 8, 2024 • edited

cmsbuild commented Mar 8, 2024

cmsbuild commented Mar 8, 2024

tjavaid commented Mar 8, 2024

cmsbuild commented Mar 8, 2024

RelVals

RelVals-INPUT

AddOn Tests

24LopezR commented Mar 11, 2024

cmsbuild commented Mar 11, 2024

tjavaid commented Mar 12, 2024

cmsbuild commented Mar 12, 2024

Comparison Summary

tjavaid commented Mar 27, 2024

cmsbuild commented Mar 27, 2024

Comparison Summary

tjavaid commented Apr 2, 2024

cmsbuild commented Apr 2, 2024

antoniovilela commented Apr 2, 2024

cmsbuild commented Mar 8, 2024 •

edited