Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Complete technical part of SimHit Validation for Shashlik #4440

Merged
merged 1 commit into from
Jul 4, 2014

Conversation

bsunanda
Copy link
Contributor

Shashlik SimHit Validation

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_6_2_X_SLHC.

Complete technical part of SimHit Validation for Shashlik

It involves the following packages:

Validation/ShashlikValidation

The following packages do not have a category, yet:

Validation/ShashlikValidation

@cmsbuild, @Degano, @ktf, @nclopezo can you please review it and eventually sign? Thanks.
You can sign-off by replying to this message having '+1' in the first line of your reply.
You can reject by replying to this message having '-1' in the first line of your reply.
@fratnikov, @mark-grimes you are the release manager for this.
You can merge this pull request by typing 'merge' in the first line of your comment.

@cmsbuild
Copy link
Contributor

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 4, 2014

Hi

I see this is having a new-package-pending message whereas this package is
already in the existing IB's. It was a new package sometime earlier but
not true for this pull request. I am confused.

Sunanda

On Mon, 30 Jun 2014, cmsbuild wrote:

+1
Tested at: 2f8d905
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44
40/11/summary.html


Reply to this email directly or view it onGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTc0MD
E2NiwiZGF0YSI6eyJpZCI6MzU3OTEyNDN9fQ==--c5d1b947f5dc10956f4e1297581bb431179
6c545.gif]

@davidlange6
Copy link
Contributor

HI Sunanda

I think this just means a package is not listed in

https://github.com/cms-sw/topic-collector/blob/master/categories.py

which needs to be updated (You can make a PR if you wish)

On Jul 4, 2014, at 5:42 AM, bsunanda notifications@github.com
wrote:

Hi

I see this is having a new-package-pending message whereas this package is
already in the existing IB's. It was a new package sometime earlier but
not true for this pull request. I am confused.

Sunanda

On Mon, 30 Jun 2014, cmsbuild wrote:

+1
Tested at: 2f8d905
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44
40/11/summary.html


Reply to this email directly or view it onGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTc0MD
E2NiwiZGF0YSI6eyJpZCI6MzU3OTEyNDN9fQ==--c5d1b947f5dc10956f4e1297581bb431179
6c545.gif]


Reply to this email directly or view it on GitHub.

@bsunanda
Copy link
Contributor Author

bsunanda commented Jul 4, 2014

Hi

I donot know how to get this file, edit and submit. I shall wait for some
expert to do that. Regards

Sunanda

On Fri, 4 Jul 2014, David Lange wrote:

HI Sunanda

I think this just means a package is not listed in

https://github.com/cms-sw/topic-collector/blob/master/categories.py

which needs to be updated (You can make a PR if you wish)

On Jul 4, 2014, at 5:42 AM, bsunanda notifications@github.com
wrote:

Hi

I see this is having a new-package-pending message whereas this package is
already in the existing IB's. It was a new package sometime earlier but
not true for this pull request. I am confused.

Sunanda

On Mon, 30 Jun 2014, cmsbuild wrote:

+1
Tested at: 2f8d905
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-44

40/11/summary.html


Reply to this email directly or view itonGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcxOTc0
MD
E2NiwiZGF0YSI6eyJpZCI6MzU3OTEyNDN9fQ==--c5d1b947f5dc10956f4e1297581bb431179

6c545.gif]


Reply to this email directly or view it on GitHub.


Reply to this email directly or view it onGitHub.[5033146__eyJzY29wZSI6Ik5ld3NpZXM6QmVhY29uIiwiZXhwaXJlcyI6MTcyMDA3Mj
M4MCwiZGF0YSI6eyJpZCI6MzU3OTEyNDN9fQ==--153097644b67480240f9d9da1ea43867273
98b1f.gif]

@mark-grimes
Copy link

merge

Tested all scenarios with muons and pions, only the known problems in HGCal validation. I can look at editing the package list. Most other validation packages are in the DQM category, or do we need a new upgrade specific group?

cmsbuild added a commit that referenced this pull request Jul 4, 2014
Complete technical part of SimHit Validation for Shashlik
@cmsbuild cmsbuild merged commit 9cc9cad into cms-sw:CMSSW_6_2_X_SLHC Jul 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants