Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated b tag algorithms and WP values for top production (backport from commit 8e014ec7c6ddece9d1cec7007a76681f8d77592a to master) (PR number #44299) #44403

Merged
merged 1 commit into from
Mar 22, 2024

Conversation

dsidirop1
Copy link
Contributor

@dsidirop1 dsidirop1 commented Mar 14, 2024

Backport from commit 8e014ec to master of changes to b-tag algorithms and WP values for top production for mini AOD.

PR number #44299

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2024

A new Pull Request was created by @dsidirop1 for CMSSW_14_0_X.

It involves the following packages:

  • DQM/Physics (dqm)

@rvenditti, @cmsbuild, @tjavaid, @syuvivida, @nothingface0, @antoniovagnerini can you please review it and eventually sign? Thanks.
@rappoccio this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 14, 2024

cms-bot internal usage

@tjavaid
Copy link

tjavaid commented Mar 21, 2024

backport of #44299

@tjavaid
Copy link

tjavaid commented Mar 21, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-7d58fd/38317/summary.html
COMMIT: 90b9149
CMSSW: CMSSW_14_0_X_2024-03-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44403/38317/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 4 lines to the logs
  • Reco comparison results: 45 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3345372
  • DQMHistoTests: Total failures: 81
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3345269
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 3.2899999999999987 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 10224.0,... ): 0.094 KiB Physics/Top
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@tjavaid
Copy link

tjavaid commented Mar 21, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

Backport from commit 8e014ec to master of changes to b-tag algorithms and WP values for top production for mini AOD.

@dsidirop1
Please update title and description to refer to the PR number.

@dsidirop1 dsidirop1 changed the title Updated b tag algorithms and WP values for top production (backport from commit 8e014ec7c6ddece9d1cec7007a76681f8d77592a to master) Updated b tag algorithms and WP values for top production (backport from commit 8e014ec7c6ddece9d1cec7007a76681f8d77592a to master) PR number #44299 Mar 22, 2024
@dsidirop1 dsidirop1 changed the title Updated b tag algorithms and WP values for top production (backport from commit 8e014ec7c6ddece9d1cec7007a76681f8d77592a to master) PR number #44299 Updated b tag algorithms and WP values for top production (backport from commit 8e014ec7c6ddece9d1cec7007a76681f8d77592a to master) (PR number #44299) Mar 22, 2024
@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 8202a6d into cms-sw:CMSSW_14_0_X Mar 22, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants