Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] KalmanFilter fix for Phase 2 L1 tracking #44457

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

aehart
Copy link
Contributor

@aehart aehart commented Mar 18, 2024

PR description:

This PR resolves the failure reported in #44306. The problem was that matRinv is defined as a 2×2 matrix:
https://github.com/cms-sw/cmssw/blob/CMSSW_14_0_0/L1Trigger/TrackFindingTMTT/src/KFbase.cc#L549
while unitMatrix is defined as a 5×5 matrix (nHelixPar_ is five when running the extended tracking):
https://github.com/cms-sw/cmssw/blob/CMSSW_14_0_0/L1Trigger/TrackFindingTMTT/src/KFbase.cc#L554

So then there is an exception caused by assigning one to the other on this line:
https://github.com/cms-sw/cmssw/blob/CMSSW_14_0_0/L1Trigger/TrackFindingTMTT/src/KFbase.cc#L556
Hence the error message:

…
[a] Fatal Root Error: @SUB=operator=(const TMatrixT &)
matrices not compatible

PR validation:

A recipe for reproducing the exception can be found in #44306. The changes in this PR allow the recipe to run without any exception.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Original PR: #44427

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2024

A new Pull Request was created by @aehart for CMSSW_14_0_X.

It involves the following packages:

  • L1Trigger/TrackFindingTMTT (l1)

@aloeliger, @epalencia, @cmsbuild can you please review it and eventually sign? Thanks.
@Martin-Grunewald, @missirol, @erikbutz, @skinnari this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 18, 2024

cms-bot internal usage

@aloeliger
Copy link
Contributor

Backport of #44427

@aloeliger
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d53062/38388/summary.html
COMMIT: 7a4d565
CMSSW: CMSSW_14_0_X_2024-03-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44457/38388/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 164 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 58 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3243082
  • DQMHistoTests: Total failures: 1355
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3241705
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 163 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

type bug-fix

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit f90edc3 into cms-sw:CMSSW_14_0_X Mar 27, 2024
10 checks passed
@aehart aehart deleted the kf_matrix_fix branch May 15, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants