Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14_0_X] Add use of unsubtracted jets in RecoBTag info producers #44474

Merged

Conversation

stahlleiton
Copy link
Contributor

PR description:

backport of #44422

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

@mandrenguyen

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024

A new Pull Request was created by @stahlleiton for CMSSW_14_0_X.

It involves the following packages:

  • RecoBTag/FeatureTools (reconstruction)
  • RecoJets/JetProducers (reconstruction)

@cmsbuild, @mandrenguyen, @jfernan2 can you please review it and eventually sign? Thanks.
@rappoccio, @jdamgov, @jdolen, @AlexDeMoor, @schoef, @emilbols, @nhanvtran, @ahinzmann, @yslai, @gkasieczka, @andrzejnovak, @Ming-Yan, @clelange, @seemasharmafnal, @AnnikaStein, @hqucms, @JyothsnaKomaragiri, @missirol, @Senphy, @mariadalfonso, @demuller this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024

cms-bot internal usage

@mandrenguyen
Copy link
Contributor

backport of #44422

@mandrenguyen
Copy link
Contributor

type btv

@cmsbuild cmsbuild added the btv label Mar 21, 2024
@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0da76a/38320/summary.html
COMMIT: 3eb9c68
CMSSW: CMSSW_14_0_X_2024-03-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44474/38320/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 6 lines to the logs
  • Reco comparison results: 46 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346212
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346181
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

@cmsbuild
Copy link
Contributor

Pull request #44474 was updated. @jfernan2, @cmsbuild, @mandrenguyen can you please check and sign again.

@mandrenguyen
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-0da76a/38371/summary.html
COMMIT: 4f59df3
CMSSW: CMSSW_14_0_X_2024-03-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44474/38371/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@mandrenguyen
Copy link
Contributor

+reconstruction
Has no effect on any workflow, so this is fine for a closed release.

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit bdd404a into cms-sw:CMSSW_14_0_X Mar 31, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants