Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-gex177X Backport #44493 (Make a new PR to have the geometry scenario ExtendedGeometry2026D110 which represents T35+C18+M11+I17+O9+F8) #44494

Merged
merged 1 commit into from
Mar 25, 2024

Conversation

bsunanda
Copy link
Contributor

PR description:

Backport #44493 (Make a new PR to have the geometry scenario ExtendedGeometry2026D110 which represents T35+C18+M11+I17+O9+F8)

PR validation:

Use the workflow 29634.0 which uses the scenario 2026D110

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is a backport of #44493

…tendedGeometry2026D110 which represents T35+C18+M11+I17+O9+F8)
@cmsbuild
Copy link
Contributor

A new Pull Request was created by @bsunanda for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/Geometry (geometry, upgrade)
  • Configuration/PyReleaseValidation (pdmv, upgrade)
  • Configuration/StandardSequences (operations)
  • Geometry/CMSCommonData (geometry, upgrade)

@mdhildreth, @bsunanda, @Dr15Jones, @subirsarkar, @miquork, @cmsbuild, @makortel, @rappoccio, @antoniovilela, @fabiocos, @sunilUIET, @davidlange6, @srimanob, @civanch, @AdrianoDee can you please review it and eventually sign? Thanks.
@vargasa, @mmusich, @rovere, @mtosi, @VourMa, @sameasy, @makortel, @missirol, @JanFSchulte, @GiacomoSguazzoni, @Martin-Grunewald, @VinInn, @dgulhan, @fabiocos, @slomeo, @felicepantaleo this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024

cms-bot internal usage

@bsunanda
Copy link
Contributor Author

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28fd03/38308/summary.html
COMMIT: 64e336b
CMSSW: CMSSW_14_0_X_2024-03-20-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44494/38308/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@bsunanda
Copy link
Contributor Author

+geometry

@bsunanda
Copy link
Contributor Author

@sunilUIET @srimanob Please approve this PR

@srimanob
Copy link
Contributor

@cmsbuild please test workflow 29634.0

@cmsbuild
Copy link
Contributor

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28fd03/38318/summary.html
COMMIT: 64e336b
CMSSW: CMSSW_14_0_X_2024-03-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44494/38318/install.sh to create a dev area with all the needed externals and cmssw changes.

Unit Tests

I found 1 errors in the following unit tests:

---> test test-das-selected-lumis had ERRORS

Comparison Summary

Summary:

@srimanob
Copy link
Contributor

srimanob commented Mar 21, 2024

+Upgrade

The new workflow runs fine.

The unit test failure does not relate to this PR. It comes from missing
/HIHardProbes/HIRun2018A-v1/RAW run=326479

@bsunanda
Copy link
Contributor Author

@sunilUIET Please approve this PR

@sunilUIET
Copy link
Contributor

+pdmv

@antoniovilela
Copy link
Contributor

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-28fd03/38380/summary.html
COMMIT: 64e336b
CMSSW: CMSSW_14_0_X_2024-03-25-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44494/38380/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 138 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 65 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3243082
  • DQMHistoTests: Total failures: 1355
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3241705
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 163 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 1ab1183 into cms-sw:CMSSW_14_0_X Mar 25, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants