Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify trigger filterBits for electrons and photons in custom EGM Nano #44496

Merged
merged 2 commits into from Mar 22, 2024

Conversation

RSalvatico
Copy link
Contributor

PR description:

This PR modifies the filterBits content for the TrigObjs with id = 11 and id = 22 (electrons and photons, respectively) in the custom EGM Nano only, to better suit the current needs of the POG.

PR validation:

Checked that we get credible results in terms of trigger objects, IDs and pT thresholds when requesting each of the filterBits to be on. One workflow that can be used is

runTheMatrix.py -l 2500.315 --sites ''

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 20, 2024

cms-bot internal usage

@RSalvatico
Copy link
Contributor Author

type egamma

@cmsbuild
Copy link
Contributor

@cmsbuild
Copy link
Contributor

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44496/39603

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

A new Pull Request was created by @RSalvatico for master.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@vlimant, @hqucms, @cmsbuild can you please review it and eventually sign? Thanks.
@gpetruc, @AnnikaStein this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@hqucms
Copy link
Contributor

hqucms commented Mar 20, 2024

enable nano

@hqucms
Copy link
Contributor

hqucms commented Mar 20, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d36d5f/38312/summary.html
COMMIT: 2bba720
CMSSW: CMSSW_14_1_X_2024-03-20-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44496/38312/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

NANO Comparison Summary

Summary:

  • You potentially removed 2 lines from the logs
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16402
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 14 files compared)
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.548 2.548 0.000 ( +0.0% ) 5.27 5.23 +0.8% 2.239 2.212
2500.001 2.698 2.698 0.000 ( +0.0% ) 4.71 4.68 +0.6% 2.655 2.560
2500.002 2.638 2.638 0.000 ( +0.0% ) 4.91 4.85 +1.2% 2.659 2.546
2500.01 1.318 1.318 0.000 ( +0.0% ) 9.83 9.58 +2.6% 2.325 2.273
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.27 5.26 +0.1% 2.500 2.456
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.57 7.42 +2.1% 2.444 2.334
2500.1 2.192 2.192 0.000 ( +0.0% ) 5.31 5.28 +0.5% 2.066 2.069
2500.2 2.308 2.308 0.000 ( +0.0% ) 6.08 5.99 +1.5% 1.976 1.975
2500.21 1.181 1.181 0.000 ( +0.0% ) 4.32 4.32 -0.2% 2.257 2.270
2500.211 1.545 1.545 0.000 ( +0.0% ) 3.80 3.68 +3.1% 2.339 2.346
2500.3 2.058 2.058 0.000 ( +0.0% ) 12.63 12.34 +2.3% 1.966 1.963
2500.301 2.630 2.631 -0.001 ( -0.0% ) 10.46 10.21 +2.4% 1.944 1.949
2500.31 1.254 1.254 0.000 ( +0.0% ) 20.08 19.33 +3.9% 2.355 2.343
2500.311 1.640 1.640 0.000 ( +0.0% ) 14.02 13.65 +2.7% 2.425 2.436
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.47 1.40 +5.2% 1.705 1.704
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.55 7.14 -8.3% 1.055 1.053
2500.314 1.163 1.163 0.000 ( +0.0% ) 14.76 14.10 +4.7% 2.211 2.074
2500.315 1.756 1.758 -0.003 ( -0.1% ) 14.17 13.66 +3.7% 2.313 2.315
2500.316 3.091 3.091 0.000 ( +0.0% ) 2.28 2.24 +1.4% 2.275 1.976
2500.317 1.787 1.787 0.000 ( +0.0% ) 13.72 13.36 +2.7% 2.158 2.170
2500.4 2.058 2.058 0.000 ( +0.0% ) 12.46 12.30 +1.3% 1.925 1.839
2500.401 1.824 1.824 0.000 ( +0.0% ) 10.46 10.38 +0.7% 1.691 1.687
2500.402 2.630 2.631 -0.001 ( -0.0% ) 10.12 10.13 -0.1% 1.951 1.955
2500.403 5.188 5.188 0.000 ( +0.0% ) 1.58 1.56 +0.8% 1.893 1.908
2500.404 2.620 2.620 0.000 ( +0.0% ) 10.10 9.36 +7.9% 1.754 1.767
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.27 1.23 +3.7% 1.365 1.356

@hqucms
Copy link
Contributor

hqucms commented Mar 22, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants