Update 2024 geometry and GEM alignment conditions in 2024 MC GTs #44497

saumyaphor4252 · 2024-03-20T19:02:51Z

PR description:

The PR updates the 2024 geometry and compatible GEM alignment conditions tags in the relevant MC GTs:

140X_mcRun3_2024_design_v6
140X_mcRun3_2024_realistic_v7
140X_mcRun3_2024cosmics_realistic_deco_v7
140X_mcRun3_2024cosmics_design_deco_v5
141X_mcRun3_2024_realistic_HI_v2

More details with the full list of tag updates and links to relevant presentations can be found in the CMS Talk request in [1].

FYI @bsunanda @watson-ij @hyunyong @mrcthiel @jhgoh

An additional key phase1_2024_realistic_hi is added in preparation for the 2024 HI MC GT. The key is not consumed anywhere at this point of time but can be used once new workflows for 2024 HI are included.

[1] https://cms-talk.web.cern.ch/t/gt-mc-data-update-of-2024-gem-and-rpc-geomtery-conditions-for-data-and-mc/36739

GT Differences with the last ones are here:

Phase1 2024 design:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2024_design_v3/140X_mcRun3_2024_design_v6
Phase1 2024 realistic:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2024_realistic_v4/140X_mcRun3_2024_realistic_v7
Phase1 2024 cosmics realistic:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2024cosmics_realistic_deco_v4/140X_mcRun3_2024cosmics_realistic_deco_v7
Phase1 2024 cosmics design:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/140X_mcRun3_2024cosmics_design_deco_v2/140X_mcRun3_2024cosmics_design_deco_v5
Phase1 2024 realistic hi:
https://cms-conddb.cern.ch/cmsDbBrowser/diff/Prod/gts/141X_mcRun3_2024_realistic_HI_v1/141X_mcRun3_2024_realistic_HI_v2

PR validation:

Since there are limited 2024 workflows for testing all the changed GT keys, one GT each (realistic and design) has been tested using the existing 2024 realistic workflows:

runTheMatrix.py -l 13050.0,13049.0,13046.0,13045.0,13040.0,12933.0,12841.0,12802.0,12824.0,12834.1,13052.0 --what upgrade -j 10 --ibeos
runTheMatrix.py -l 13050.0,13049.0,13046.0,13045.0,13040.0,12933.0,12841.0,12802.0,12824.0,12834.1,13052.0 --what upgrade -j 10 --ibeos --command "--conditions 140X_mcRun3_2024_design_Candidate_2024_03_20_16_03_10"

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. Backport to 140X will be needed

cmsbuild · 2024-03-20T19:03:12Z

cms-bot internal usage

cmsbuild · 2024-03-20T19:07:57Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44497/39601

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/AlCa/python/autoCond.py modified in PR(s): Update of the Phase-2 GMT Emulator #44319, [Dummy] Try creating big-enough cache to cause splitting #44368

cmsbuild · 2024-03-20T19:08:18Z

A new Pull Request was created by @saumyaphor4252 for master.

It involves the following packages:

Configuration/AlCa (alca)

@consuegs, @saumyaphor4252, @cmsbuild, @perrotta can you please review it and eventually sign? Thanks.
@fabiocos, @rsreds, @Martin-Grunewald, @tocheng, @yuanchao, @missirol, @mmusich this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

cmsbuild · 2024-03-21T07:48:18Z

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44497/39613

This PR adds an extra 12KB to repository
There are other open Pull requests which might conflict with changes you have proposed:
- File Configuration/AlCa/python/autoCond.py modified in PR(s): [Dummy] Try creating big-enough cache to cause splitting #44368

cmsbuild · 2024-03-21T07:48:44Z

Pull request #44497 was updated. @consuegs, @cmsbuild, @saumyaphor4252, @perrotta can you please check and sign again.

saumyaphor4252 · 2024-03-21T07:51:17Z

test parameters:

workflows = 13050.0,13049.0,13046.0,13045.0,13040.0,12933.0,12841.0,12802.0,12824.0,12834.1,13052.0
relvals_opt = --what upgrade,standard

saumyaphor4252 · 2024-03-21T07:53:10Z

@cmsbuild please test

cmsbuild · 2024-03-21T09:49:13Z

-1

Failed Tests: RelVals
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f2773/38319/summary.html
COMMIT: 4b8a6e6
CMSSW: CMSSW_14_1_X_2024-03-20-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44497/38319/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

RelVals

13045.013045.0_DYtoTauTau_M_50_14TeV+2024PU/step1_DYtoTauTau_M_50_14TeV+2024PU.log

perrotta · 2024-03-21T11:23:45Z

The error in wf 13045 is unrelated, and a fix for it (affecting Generators) is now available in #44499
Let retest this PR without that unrelatedly failing workflow

perrotta · 2024-03-21T11:30:20Z

test parameters:

workflows = 13050.0,13049.0,13046.0,13040.0,12933.0,12841.0,12802.0,12824.0,12834.1,13052.0
relvals_opt = --what upgrade,standard

perrotta · 2024-03-21T11:31:20Z

please test

cmsbuild · 2024-03-22T11:36:58Z

Pull request #44497 was updated. @cmsbuild, @consuegs, @perrotta, @saumyaphor4252 can you please check and sign again.

saumyaphor4252 · 2024-03-22T11:38:12Z

please test

cmsbuild · 2024-03-22T21:26:17Z

-1

Failed Tests: UnitTests
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f2773/38342/summary.html
COMMIT: 1a9594b
CMSSW: CMSSW_14_1_X_2024-03-21-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44497/38342/install.sh to create a dev area with all the needed externals and cmssw changes.

The following merge commits were also included on top of IB + this PR after doing git cms-merge-topic:

@smorovic HLT XGBoost Photon MVA and Diphoton combination filter #44473

You can see more details here:
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f2773/38342/git-recent-commits.json
https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f2773/38342/git-merge-result

Unit Tests

I found 1 errors in the following unit tests:

---> test RecoEgammaPhotonIdentificationTest had ERRORS

Comparison Summary

Summary:

You potentially removed 159 lines from the logs
Reco comparison results: 27497 differences found in the comparisons
DQMHistoTests: Total files compared: 58
DQMHistoTests: Total histograms compared: 4868295
DQMHistoTests: Total failures: 70386
DQMHistoTests: Total nulls: 54
DQMHistoTests: Total successes: 4797835
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 2489.2959999999994 KiB( 57 files compared)
DQMHistoSizes: changed ( 12834.0,... ): 111.859 KiB GEM/RecHits
DQMHistoSizes: changed ( 12834.0,... ): 75.433 KiB GEM/Digis
DQMHistoSizes: changed ( 12834.0,... ): 1.781 KiB GEM/DAQStatus
DQMHistoSizes: changed ( 12834.0,... ): 1.094 KiB GEM/EventInfo
DQMHistoSizes: changed ( 12834.0,... ): 0.614 KiB GEM/SimHits
DQMHistoSizes: changed ( 12834.0,... ): 0.531 KiB GEM/Pad
DQMHistoSizes: changed ( 12834.0,... ): 0.432 KiB GEM/PadCluster
DQMHistoSizes: changed ( 13034.0 ): -0.980 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13040.0 ): -2.999 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13046.0 ): -1.470 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13050.0 ): ...
Checked 246 log files, 213 edm output root files, 58 DQM output files
TriggerResults: found differences in 11 / 56 workflows

perrotta · 2024-03-23T07:54:22Z

The unit test fails supposedly because #44473 was picked on top of CMSSW_14_1_X_2024-03-21-2300 without the necessary accompanying cmsdist update, see #44497 (comment)
Let relaunch the tests now in a fresher IB which contain both the cmssw and cmsdist PRs merged

perrotta · 2024-03-23T07:54:34Z

please test

cmsbuild · 2024-03-23T17:05:00Z

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-6f2773/38361/summary.html
COMMIT: 1a9594b
CMSSW: CMSSW_14_1_X_2024-03-22-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44497/38361/install.sh to create a dev area with all the needed externals and cmssw changes.

DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

You potentially removed 29 lines from the logs
Reco comparison results: 27486 differences found in the comparisons
DQMHistoTests: Total files compared: 58
DQMHistoTests: Total histograms compared: 4868463
DQMHistoTests: Total failures: 70385
DQMHistoTests: Total nulls: 54
DQMHistoTests: Total successes: 4798004
DQMHistoTests: Total skipped: 20
DQMHistoTests: Total Missing objects: 0
DQMHistoSizes: Histogram memory added: 2489.2959999999994 KiB( 57 files compared)
DQMHistoSizes: changed ( 12834.0,... ): 111.859 KiB GEM/RecHits
DQMHistoSizes: changed ( 12834.0,... ): 75.433 KiB GEM/Digis
DQMHistoSizes: changed ( 12834.0,... ): 1.781 KiB GEM/DAQStatus
DQMHistoSizes: changed ( 12834.0,... ): 1.094 KiB GEM/EventInfo
DQMHistoSizes: changed ( 12834.0,... ): 0.614 KiB GEM/SimHits
DQMHistoSizes: changed ( 12834.0,... ): 0.531 KiB GEM/Pad
DQMHistoSizes: changed ( 12834.0,... ): 0.432 KiB GEM/PadCluster
DQMHistoSizes: changed ( 13034.0 ): -0.980 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13040.0 ): -2.999 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13046.0 ): -1.470 KiB SiStrip/MechanicalView
DQMHistoSizes: changed ( 13050.0 ): ...
Checked 246 log files, 213 edm output root files, 58 DQM output files
TriggerResults: found differences in 11 / 56 workflows

saumyaphor4252 · 2024-03-25T16:17:37Z

+alca

Huge differences as expected from the geometry updates in the concerned 2024 MC workflows
Finer physics performance validation to be followed up in release validation

cmsbuild · 2024-03-25T16:17:57Z

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

perrotta · 2024-03-25T16:51:08Z

urgent
(to be included in the pre-release planned for March 26)

mmusich · 2024-03-25T17:14:40Z

Well that's what was provided to us.

I think it should have been asked to provide better tag names in the cmsTalk, well before cutting Global Tags

Huge differences as expected from the geometry updates in the concerned 2024 MC workflows

out of curiosity, do we understand why certain 2024 wfs (e.g. 13049.0 overlay GUI or 12933.0 overlay GUI ) instead have only moderate changes (and all in the GEM folder)?

antoniovilela · 2024-03-25T23:59:44Z

+1

cmsbuild added this to the CMSSW_14_1_X milestone Mar 20, 2024

cmsbuild added alca-pending pending-signatures tests-pending orp-pending code-checks-pending labels Mar 20, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 20, 2024

cmsbuild added code-checks-pending and removed code-checks-approved labels Mar 21, 2024

cmsbuild added code-checks-approved and removed code-checks-pending labels Mar 21, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 21, 2024

cmsbuild added tests-rejected and removed tests-started labels Mar 21, 2024

civanch mentioned this pull request Mar 21, 2024

Phase2-gex177 Make a new PR to have the geometry scenario ExtendedGeometry2026D110 which represents T35+C18+M11+I17+O9+F8 #44493

Merged

perrotta mentioned this pull request Mar 21, 2024

Add missing import of TauolaPolar PSet in one Generator config #44499

Merged

cmsbuild removed the tests-rejected label Mar 21, 2024

cmsbuild added the code-checks-approved label Mar 22, 2024

cmsbuild added tests-started and removed tests-pending labels Mar 22, 2024

saumyaphor4252 mentioned this pull request Mar 22, 2024

[14.0.X] Update 2024 geometry and GEM alignment conditions in 2024 MC GTs #44512

Merged

cmsbuild added tests-rejected and removed tests-started labels Mar 22, 2024

cmsbuild added tests-started and removed tests-rejected labels Mar 23, 2024

perrotta mentioned this pull request Mar 23, 2024

HLT XGBoost Photon MVA and Diphoton combination filter #44473

Merged

cmsbuild added tests-approved and removed tests-started labels Mar 23, 2024

cmsbuild added alca-approved fully-signed and removed alca-pending pending-signatures labels Mar 25, 2024

cmsbuild added the urgent label Mar 25, 2024

cmsbuild added orp-approved and removed orp-pending labels Mar 26, 2024

cmsbuild merged commit 5df6c60 into cms-sw:master Mar 26, 2024
12 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update 2024 geometry and GEM alignment conditions in 2024 MC GTs #44497

Update 2024 geometry and GEM alignment conditions in 2024 MC GTs #44497

saumyaphor4252 commented Mar 20, 2024 •

edited

cmsbuild commented Mar 20, 2024 •

edited

cmsbuild commented Mar 20, 2024

cmsbuild commented Mar 20, 2024

cmsbuild commented Mar 21, 2024

cmsbuild commented Mar 21, 2024

saumyaphor4252 commented Mar 21, 2024

saumyaphor4252 commented Mar 21, 2024

cmsbuild commented Mar 21, 2024

perrotta commented Mar 21, 2024

perrotta commented Mar 21, 2024

perrotta commented Mar 21, 2024

cmsbuild commented Mar 22, 2024

saumyaphor4252 commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

perrotta commented Mar 23, 2024

perrotta commented Mar 23, 2024

cmsbuild commented Mar 23, 2024

saumyaphor4252 commented Mar 25, 2024

cmsbuild commented Mar 25, 2024

perrotta commented Mar 25, 2024

mmusich commented Mar 25, 2024

antoniovilela commented Mar 25, 2024

Update 2024 geometry and GEM alignment conditions in 2024 MC GTs #44497

Update 2024 geometry and GEM alignment conditions in 2024 MC GTs #44497

Conversation

saumyaphor4252 commented Mar 20, 2024 • edited

PR description:

PR validation:

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

cmsbuild commented Mar 20, 2024 • edited

cmsbuild commented Mar 20, 2024

cmsbuild commented Mar 20, 2024

cmsbuild commented Mar 21, 2024

cmsbuild commented Mar 21, 2024

saumyaphor4252 commented Mar 21, 2024

saumyaphor4252 commented Mar 21, 2024

cmsbuild commented Mar 21, 2024

RelVals

perrotta commented Mar 21, 2024

perrotta commented Mar 21, 2024

perrotta commented Mar 21, 2024

cmsbuild commented Mar 22, 2024

saumyaphor4252 commented Mar 22, 2024

cmsbuild commented Mar 22, 2024

Unit Tests

Comparison Summary

perrotta commented Mar 23, 2024

perrotta commented Mar 23, 2024

cmsbuild commented Mar 23, 2024

Comparison Summary

saumyaphor4252 commented Mar 25, 2024

cmsbuild commented Mar 25, 2024

perrotta commented Mar 25, 2024

mmusich commented Mar 25, 2024

antoniovilela commented Mar 25, 2024

saumyaphor4252 commented Mar 20, 2024 •

edited

cmsbuild commented Mar 20, 2024 •

edited