Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseMVAValueMapProducer and new Prompt lepton MVA [Backport] #44504

Merged
merged 12 commits into from
Apr 3, 2024

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Mar 21, 2024

A backport of #44322 / #44503 and #44392 to 14.0

@vlimant
Copy link
Contributor Author

vlimant commented Mar 21, 2024

test parameters:

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Mar 21, 2024
@vlimant
Copy link
Contributor Author

vlimant commented Mar 21, 2024

type muon

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 21, 2024

A new Pull Request was created by @vlimant for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)
  • PhysicsTools/PatAlgos (xpog, reconstruction)

@vlimant, @cmsbuild, @jfernan2, @mandrenguyen, @hqucms can you please review it and eventually sign? Thanks.
@mbluj, @hatakeyamak, @jdamgov, @gpetruc, @JyothsnaKomaragiri, @ahinzmann, @mmarionncern, @AlexDeMoor, @andrzejnovak, @mariadalfonso, @rappoccio, @AnnikaStein, @azotz, @gouskos, @Senphy, @emilbols, @Ming-Yan, @jdolen, @schoef, @demuller, @nhanvtran, @gkasieczka, @seemasharmafnal this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 21, 2024

cms-bot internal usage

@cmsbuild cmsbuild added the muon label Mar 21, 2024
@vlimant
Copy link
Contributor Author

vlimant commented Mar 21, 2024

type jetmet

@vlimant
Copy link
Contributor Author

vlimant commented Mar 21, 2024

enable nano

@cmsbuild
Copy link
Contributor

Pull request #44504 was updated. @hqucms, @jfernan2, @fabiocos, @davidlange6, @antoniovilela, @vlimant, @cmsbuild, @rappoccio, @mandrenguyen can you please check and sign again.

@vlimant
Copy link
Contributor Author

vlimant commented Mar 21, 2024

type egamma

@vlimant
Copy link
Contributor Author

vlimant commented Mar 21, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-f1effd/38481/summary.html
COMMIT: c850197
CMSSW: CMSSW_14_0_X_2024-03-27-2300/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44504/38481/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 57 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346070
  • DQMHistoTests: Total failures: 1355
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3344693
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.23400000000000007 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.018 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.012 KiB Physics/NanoAODDQM
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially added 1 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 28 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16332
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16332
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.21 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.018 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 0.012 KiB Physics/NanoAODDQM
  • Checked 43 log files, 23 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.548 2.548 0.000 ( +0.0% ) 5.25 5.30 -0.8% 2.164 2.229
2500.001 2.698 2.698 0.000 ( +0.0% ) 4.71 4.73 -0.4% 2.578 2.643
2500.002 2.638 2.638 0.000 ( +0.0% ) 4.89 4.90 -0.3% 2.577 2.649
2500.01 1.318 1.318 0.000 ( +0.0% ) 9.60 9.85 -2.6% 2.261 2.348
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.20 5.26 -1.1% 2.433 2.533
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.41 7.55 -1.8% 2.379 2.378
2500.1 2.192 2.192 0.000 ( +0.0% ) 5.32 5.32 +0.1% 2.070 2.069
2500.2 2.308 2.308 0.000 ( +0.0% ) 6.08 6.06 +0.4% 1.899 1.977
2500.21 1.181 1.181 0.000 ( +0.0% ) 4.33 4.33 +0.1% 2.260 2.284
2500.211 1.545 1.545 0.000 ( +0.0% ) 3.78 3.79 -0.3% 2.242 2.370
2500.3 2.058 2.058 0.001 ( +0.0% ) 12.77 12.76 +0.0% 1.969 1.969
2500.301 2.631 2.631 0.000 ( +0.0% ) 10.44 10.42 +0.2% 1.961 1.957
2500.31 1.254 1.254 0.000 ( +0.0% ) 20.23 20.15 +0.4% 2.364 2.367
2500.311 1.640 1.640 0.000 ( +0.0% ) 13.26 13.95 -5.0% 2.432 2.447
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.46 1.47 -0.6% 1.697 1.694
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.21 6.96 -10.8% 1.049 1.053
2500.314 1.163 1.163 0.000 ( +0.0% ) 14.12 14.96 -5.6% 2.062 2.218
2500.315 1.758 1.758 0.000 ( +0.0% ) 14.19 14.23 -0.3% 2.334 2.332
2500.4 2.058 2.058 0.001 ( +0.0% ) 12.51 12.63 -1.0% 1.865 1.888
2500.401 1.824 1.824 0.000 ( +0.0% ) 10.69 10.86 -1.6% 1.731 1.822
2500.402 2.631 2.631 0.000 ( +0.0% ) 10.07 10.22 -1.4% 1.888 1.820
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.30 1.29 +0.1% 1.125 1.275

@vlimant
Copy link
Contributor Author

vlimant commented Mar 30, 2024

@cms-sw/orp-l2 : we will need this for 14.0 Nano production. @hqucms or I will try to join the ORP next week to discuss this. I don’t see anything too controversial about it though.

@mandrenguyen
Copy link
Contributor

backport of #44503

@mandrenguyen
Copy link
Contributor

+reconstruction
There was some discussion at the last ORP about whether this complies with the no-change rule. IIUC it only touches nano, so that should be ok.

@antoniovilela
Copy link
Contributor

@cms-sw/orp-l2 : we will need this for 14.0 Nano production. @hqucms or I will try to join the ORP next week to discuss this. I don’t see anything too controversial about it though.

@vlimant @cms-sw/ppd-l2
We have this and a few more for the Nano production with 14_0_X. Please highlight all that are needed in the ORP meeting next Tue, and we can target them for a following 14_0_X build (after 14_0_4).
Thanks.

@vlimant vlimant changed the title BaseMVAValueMapProducer and new Prompt MVA [Backport] BaseMVAValueMapProducer and new Prompt lepton MVA [Backport] Apr 2, 2024
@antoniovilela
Copy link
Contributor

@cms-sw/xpog-l2
In order to pick up the cms-data update, you need to backport the cmsdist PR cms-sw/cmsdist#9105 to 14_0_X, which updates the PhysicsTools-NanoAOD tag in cmsswdata.txt.

@vlimant
Copy link
Contributor Author

vlimant commented Apr 3, 2024

is this what you had in mind cms-sw/cmsdist#9110

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit a007c9e into cms-sw:CMSSW_14_0_X Apr 3, 2024
13 checks passed
@vlimant vlimant deleted the backport_44392_44322 branch April 7, 2024 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants