[CLANG_X] Use generated copy ctor in FTLDataFrameT

[iarspider]

PR description:

This avoids Clang warning:

 <...>/CMSSW_14_1_CLANG_X_2024-03-24-2300/src/DataFormats/FTLDigi/interface/FTLDataFrameT.h:26:3: warning: definition of implicit copy assignment operator for 'FTLDataFrameT<BTLDetId, BTLSample, mtdhelpers::BTLRowColDecode>' is deprecated because it has a user-provided copy constructor [-Wdeprecated-copy-with-user-provided-copy]
    26 |   FTLDataFrameT(const FTLDataFrameT& o) : data_(o.data_), id_(o.id_), maxSampleSize_(o.maxSampleSize_) {}
      |   ^

PR validation:

Bot tests

[iarspider]

please test for CMSSW_14_1_CLANG_X

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44528/39660

• This PR adds an extra 16KB to repository

[cmsbuild]

A new Pull Request was created by @iarspider for master.

It involves the following packages:

• DataFormats/FTLDigi (upgrade, simulation)

@subirsarkar, @mdhildreth, @civanch, @srimanob can you please review it and eventually sign? Thanks.
@missirol, @fabiocos, @rovere this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a60b9f/38376/summary.html
COMMIT: b87705e
CMSSW: CMSSW_14_1_CLANG_X_2024-03-24-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44528/38376/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 11995 lines to the logs
• Reco comparison results: 31053 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297537
• DQMHistoTests: Total failures: 53963
• DQMHistoTests: Total nulls: 234
• DQMHistoTests: Total successes: 3243320
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.008 KiB( 47 files compared)
• DQMHistoSizes: changed ( 141.042,... ): 0.004 KiB JetMET/SUSYDQM
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: found differences in 5 / 46 workflows

[civanch]

the same question as for #44530

[makortel]

@cmsbuild, please test

Let's run the default tests too to have clean(er) comparisons

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-a60b9f/38498/summary.html
COMMIT: b87705e
CMSSW: CMSSW_14_1_X_2024-03-28-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44528/38498/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 54 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3297437
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3297411
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[civanch]

+1

[srimanob]

+Upgrade

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

+1