Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unpack displaced pT from OMTF at the uGMT inputs (backport for 14_0_X) #44544

Merged

Conversation

dinyar
Copy link
Contributor

@dinyar dinyar commented Mar 26, 2024

PR description:

uGMT now uses the unconstrained pT from OMTF, so we need to unpack it. I've added the functionality to pack and unpack it in this PR.

This is a backport of #44543 because we need this deployed to the online DQM to avoid data-emulator mismatches.

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 26, 2024

A new Pull Request was created by @dinyar for CMSSW_14_0_X.

It involves the following packages:

  • EventFilter/L1TRawToDigi (l1)
  • L1Trigger/L1TMuon (l1)
  • L1Trigger/L1TNtuples (l1)

@aloeliger, @epalencia, @cmsbuild can you please review it and eventually sign? Thanks.
@JanFSchulte, @thomreis, @Martin-Grunewald, @missirol, @eyigitba, @kreczko this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Mar 26, 2024

cms-bot internal usage

@epalencia
Copy link
Contributor

Please test

@dinyar dinyar force-pushed the unpack_displaced_pt_from_omtf-14_0_X branch from ab44fd3 to d94021f Compare March 31, 2024 15:02
@cmsbuild
Copy link
Contributor

Pull request #44544 was updated. @cmsbuild, @aloeliger, @epalencia can you please check and sign again.

@aloeliger
Copy link
Contributor

Please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-cdd06e/38525/summary.html
COMMIT: d94021f
CMSSW: CMSSW_14_0_X_2024-03-31-0000/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44544/38525/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@aloeliger
Copy link
Contributor

backport of #44543

@aloeliger
Copy link
Contributor

+l1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit cfdf54e into cms-sw:CMSSW_14_0_X Apr 3, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants