[14_0_X] Protection of hcalcalib DQM client when hltHcalCalibrationRaw is not found

[syuvivida]

PR description:

In the ECAL laser test runs, run 378496 and 378498, hcalcalib DQM clients crashed with the following error:
----- Begin Fatal Exception 26-Mar-2024 15:41:37 CET----------------------- An exception of category 'ProductNotFound' occurred while [0] Processing Event run: 378496 lumi: 1 event: 5835 stream: 0 [1] Running path 'p' [2] Calling method for module HcalRawToDigi/'hcalDigis' Exception Message: Principal::getByToken: Found zero products matching all criteria Looking for type: FEDRawDataCollection Looking for module label: hltHcalCalibrationRaw Looking for productInstanceName:

Previously in 13_0_X releases, SkipEvent was used to prevent this error. The protection was removed after moving to 14_X. This PR re-introduced the protection using TryToContinue.

PR validation:

A test has been done at the playback with 14_0_3 using the DQM streamers 378496. We were able to reproduce the crash using the current hcalcalib and removed the crash (skipping events) when using the code of this PR.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This PR is a backport of PR 44545

[cmsbuild]

A new Pull Request was created by @syuvivida for CMSSW_14_0_X.

It involves the following packages:

• DQM/Integration (dqm)

@tjavaid, @antoniovagnerini, @nothingface0, @cmsbuild, @rvenditti, @syuvivida can you please review it and eventually sign? Thanks.
@francescobrivio, @threus, @batinkov this is something you requested to watch as well.
@sextonkennedy, @rappoccio, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

• Backported from Protection of hcalcalib DQM client when hltHcalCalibrationRaw is not found #44545

[cmsbuild]

cms-bot internal usage

[tjavaid]

backport of #44545

[tjavaid]

please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-2cee28/38433/summary.html
COMMIT: c288d84
CMSSW: CMSSW_14_0_X_2024-03-26-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44547/38433/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially removed 5 lines from the logs
• Reco comparison results: 45 differences found in the comparisons
• DQMHistoTests: Total files compared: 49
• DQMHistoTests: Total histograms compared: 3346148
• DQMHistoTests: Total failures: 6
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3346120
• DQMHistoTests: Total skipped: 22
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 48 files compared)
• Checked 205 log files, 166 edm output root files, 49 DQM output files
• TriggerResults: no differences found

[tjavaid]

+1

• P5 tests OK. (thanks @syuvivida )

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

[antoniovilela]

type bug-fix

[antoniovilela]

+1