Fix bug in L1 track duplicate removal for displaced tracking

[tomalin]

PR description:

This fixes two bugs in PurgeDuplicate.cc , which had been present since CMSSW 13_2, and which affected the extended (i.e. displaced) L1 tracking. One concerned the ranking of seed types, which had been accidentallly disabled for displced tracks. The other concerned the "inventStubs" option, Which had incorrectly assumed L2L3D1 seeds use L2D1 to determine the r-z helix params, whereas it is really L2L3. The inventStubs option has also been disabled until we've understood if it causes a memory leak.

It also includes a tidy up of the code in PurgeDuplicate::getInventedCoordsExtended() from @aehart .

On ttbar+200PU, the performance of the extended L1 tracking is:

Before bug fix:

efficiency (for pt > 3 GeV) = 96.46 +- 0.14%
tracks/event = 350

After bug fix:

efficiency (for Pt > 3 GeV) = 96.72 +- 0.14%
tracks/event = 262

The PR also includes minor changes to a ROOT plotting macro.

[cmsbuild]

cms-bot internal usage

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44574/39729

• This PR adds an extra 44KB to repository

[cmsbuild]

A new Pull Request was created by @tomalin for master.

It involves the following packages:

• L1Trigger/TrackFindingTracklet (l1)

@epalencia, @cmsbuild, @aloeliger can you please review it and eventually sign? Thanks.
@erikbutz, @skinnari, @Martin-Grunewald, @missirol this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

[tomalin]

Rebased to CMSSW_14_1_X_2024-04-08-1100

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44574/39862

• This PR adds an extra 64KB to repository

[cmsbuild]

Pull request #44574 was updated. @epalencia, @cmsbuild, @aloeliger can you please check and sign again.

[tomalin]

Added recent tidy up of function getInventedCoordsExteneded from plus fix by me to long-term bug in same function.
Also disabled inventStubs option until we're sure it doesn't cause a memory leak.

[cmsbuild]

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44574/39864

• This PR adds an extra 64KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

• code-format:
  https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44574/39864/code-format.patch
  e.g. curl -k https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44574/39864/code-format.patch | patch -p1
  You can also run scram build code-format to apply code format directly

[cmsbuild]

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44574/39865

• This PR adds an extra 64KB to repository

[cmsbuild]

Pull request #44574 was updated. @epalencia, @cmsbuild, @aloeliger can you please check and sign again.

[epalencia]

Please test

[cmsbuild]

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-d88fbf/38741/summary.html
COMMIT: ec9d55d
CMSSW: CMSSW_14_1_X_2024-04-10-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44574/38741/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

• You potentially added 97 lines to the logs
• Reco comparison results: 55 differences found in the comparisons
• DQMHistoTests: Total files compared: 48
• DQMHistoTests: Total histograms compared: 3316263
• DQMHistoTests: Total failures: 317
• DQMHistoTests: Total nulls: 0
• DQMHistoTests: Total successes: 3315926
• DQMHistoTests: Total skipped: 20
• DQMHistoTests: Total Missing objects: 0
• DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
• Checked 202 log files, 165 edm output root files, 48 DQM output files
• TriggerResults: no differences found

[aloeliger]

+l1

[cmsbuild]

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @rappoccio, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

[rappoccio]

+1