-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Scripts to Test MC 22-23 Production (UL-like) in IBs #44578
Conversation
cms-bot internal usage |
assign core |
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44578/39736
|
New categories assigned: core @Dr15Jones,@makortel,@smuzaffar you have been requested to review this Pull request/Issue and eventually sign? Thanks |
A new Pull Request was created by @AdrianoDee for master. It involves the following packages:
@AdrianoDee, @Dr15Jones, @smuzaffar, @sunilUIET, @makortel, @miquork, @cmsbuild, @subirsarkar, @srimanob can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
please test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a couple of typos (also missing newlines since there was recently a campaign to get rid of them).
Configuration/PyReleaseValidation/scripts/test-MC-setup_gen_sim.sh
Outdated
Show resolved
Hide resolved
Configuration/PyReleaseValidation/scripts/test-MC-setup_reco.sh
Outdated
Show resolved
Hide resolved
Configuration/PyReleaseValidation/scripts/test-MC-setup_gen_sim.sh
Outdated
Show resolved
Hide resolved
Configuration/PyReleaseValidation/scripts/test-MC-setup_reco.sh
Outdated
Show resolved
Hide resolved
Configuration/PyReleaseValidation/test/test_mc_setup/test-MC_22_setup.sh
Outdated
Show resolved
Hide resolved
Configuration/PyReleaseValidation/test/test_mc_setup/test-MC_23_setup_crosscheck.sh
Outdated
Show resolved
Hide resolved
3e1901d
to
ac1db4c
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44578/39738
|
Pull request #44578 was updated. @Dr15Jones, @AdrianoDee, @makortel, @smuzaffar, @cmsbuild, @srimanob, @subirsarkar, @sunilUIET, @miquork can you please check and sign again. |
please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-10f471/39158/summary.html Comparison SummaryThere are some workflows for which there are errors in the baseline: Summary:
|
I would say we keep the test as we can't predict what will happen :) |
+Upgrade |
We could simply keep the machinery, the scripts for future but remove the tests for |
+core (although I slightly disagree with keeping around commented-out tests, as they could pretty much as easily be resurrected from the history; but that is beyond this PR) |
+pdmv |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @sextonkennedy, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2) |
A note: for the moment I havent' commented anything. We can still go and remove them once they are no more useful. |
+1
|
This PR proposes the addition of a set of scripts to be used as IB tests to show the desired behavior of the next 2022-2023 MC campaign and to allow experts to have this run in all the IBs to follow issues and eventually find solutions. The schema for the campaign should be the following:
2022 campaign
14_0_X
;12_4_X
;14_0_X
;2023 campaign
14_0_X
;13_0_X
;14_0_X
;This setup poses some issues:
12_4_X
or13_0_X
being able to process14_0_X
samples is not granted.140X_*preEE*
and124X_*preEE*
] and [140X_*preBPix*
and130X_*preBPix*
]. Possibly having theSimBeamSpotObjectsRcd
in them, to be able to use the BS smearing from GT mechanism at GEN-SIM step.To make it less cumbersome (hopefully), I've split each step in a different script and have the different setups running the same bash script with different inputs. As they are, none of the tests technically fails. This is intentional not to have some tests that will by definition break any IB. But any suggestion there is welcome. Each script runs the HLT step in a specific target release and all the steps in the current release.
Issue (?): as they are these tests take O(100s) each (so x4).
We would need a back port to
14_0_X
to have it tested there.FYI: @cms-sw/alca-l2, @cms-sw/core-l2