Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ParticleNet C vs notB branch point in Nano [backport] #44587

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

vlimant
Copy link
Contributor

@vlimant vlimant commented Apr 2, 2024

PR description:

selecting the inclusion of btagPNetCvNotB branch from #43485

PR validation:

nano matrix

@vlimant
Copy link
Contributor Author

vlimant commented Apr 2, 2024

enable nano

@cmsbuild cmsbuild added this to the CMSSW_14_0_X milestone Apr 2, 2024
@vlimant
Copy link
Contributor Author

vlimant commented Apr 2, 2024

type jetmet

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

A new Pull Request was created by @vlimant for CMSSW_14_0_X.

It involves the following packages:

  • PhysicsTools/NanoAOD (xpog)

@hqucms, @cmsbuild, @vlimant can you please review it and eventually sign? Thanks.
@AnnikaStein, @gpetruc this is something you requested to watch as well.
@rappoccio, @antoniovilela, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

cms-bot internal usage

@vlimant
Copy link
Contributor Author

vlimant commented Apr 2, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d7614/38543/summary.html
COMMIT: 25b5518
CMSSW: CMSSW_14_0_X_2024-04-02-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44587/38543/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 136.796136.796_RunMET2017C/step2_RunMET2017C.log

Comparison Summary

Summary:

  • You potentially added 2 lines to the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 120 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346148
  • DQMHistoTests: Total failures: 9
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346117
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8.045999999999998 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.648 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.390 KiB Physics/NanoAODDQM
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 4 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16402
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16402
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 5.19 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.648 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 0.390 KiB Physics/NanoAODDQM
  • Checked 43 log files, 23 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.548 2.548 0.000 ( +0.0% ) 5.16 5.21 -0.9% 2.236 2.162
2500.001 2.698 2.698 0.000 ( +0.0% ) 4.64 4.65 -0.2% 2.672 2.591
2500.002 2.638 2.638 0.000 ( +0.0% ) 4.83 4.87 -0.8% 2.650 2.586
2500.01 1.318 1.318 0.000 ( +0.0% ) 9.48 9.33 +1.7% 2.348 2.275
2500.011 1.740 1.740 0.000 ( +0.0% ) 5.20 5.21 -0.3% 2.542 2.435
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.45 7.41 +0.5% 2.450 2.348
2500.1 2.193 2.192 0.001 ( +0.0% ) 5.23 5.28 -0.8% 2.069 1.993
2500.2 2.308 2.308 0.000 ( +0.0% ) 5.93 6.02 -1.5% 1.985 1.884
2500.21 1.182 1.181 0.001 ( +0.1% ) 4.25 4.28 -0.5% 2.270 2.211
2500.211 1.546 1.545 0.001 ( +0.1% ) 3.51 3.74 -6.1% 2.354 2.246
2500.3 2.059 2.058 0.001 ( +0.1% ) 12.01 12.52 -4.1% 1.968 1.899
2500.301 2.632 2.631 0.002 ( +0.1% ) 9.18 10.00 -8.2% 1.953 1.840
2500.31 1.255 1.254 0.001 ( +0.1% ) 18.66 19.97 -6.5% 2.370 2.277
2500.311 1.641 1.640 0.001 ( +0.1% ) 11.96 13.47 -11.2% 2.448 2.328
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.31 1.44 -9.2% 1.694 1.692
2500.313 1.564 1.564 0.000 ( +0.0% ) 5.59 6.47 -13.6% 1.050 1.043
2500.314 1.163 1.163 0.000 ( +0.0% ) 13.09 13.87 -5.6% 2.214 2.067
2500.315 1.759 1.758 0.001 ( +0.1% ) 13.08 13.92 -6.0% 2.358 2.324
2500.4 2.059 2.058 0.001 ( +0.1% ) 12.24 12.44 -1.6% 1.970 1.923
2500.401 1.824 1.824 0.000 ( +0.0% ) 9.55 10.59 -9.8% 1.818 1.817
2500.402 2.632 2.631 0.002 ( +0.1% ) 9.47 10.11 -6.3% 1.833 1.813
2500.5 19.575 19.575 0.000 ( +0.0% ) 1.16 1.21 -4.9% 1.199 1.124

@vlimant
Copy link
Contributor Author

vlimant commented Apr 3, 2024

please test
xrootd spurious issue

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

Pull request #44587 was updated. @vlimant, @hqucms, @cmsbuild can you please check and sign again.

@vlimant
Copy link
Contributor Author

vlimant commented Apr 3, 2024

please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 3, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-8d7614/38574/summary.html
COMMIT: 995e2e5
CMSSW: CMSSW_14_0_X_2024-04-03-1100/el8_amd64_gcc12
Additional Tests: NANO
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44587/38574/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially removed 5 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 115 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346180
  • DQMHistoTests: Total failures: 6
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3346152
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 8.045999999999998 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 11634.0,... ): 0.648 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 13234.0,... ): 0.390 KiB Physics/NanoAODDQM
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: no differences found

NANO Comparison Summary

Summary:

  • You potentially removed 1 lines from the logs
  • ROOTFileChecks: Some differences in event products or their sizes found
  • Reco comparison results: 0 differences found in the comparisons
  • DQMHistoTests: Total files compared: 15
  • DQMHistoTests: Total histograms compared: 16430
  • DQMHistoTests: Total failures: 0
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 16430
  • DQMHistoTests: Total skipped: 0
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 5.19 KiB( 14 files compared)
  • DQMHistoSizes: changed ( 2500.001,... ): 0.648 KiB Physics/NanoAODDQM
  • DQMHistoSizes: changed ( 2500.011,... ): 0.390 KiB Physics/NanoAODDQM
  • Checked 47 log files, 27 edm output root files, 15 DQM output files

Nano size comparison Summary:

Sample kb/ev ref kb/ev diff kb/ev ev/s/thd ref ev/s/thd diff rate mem/thd ref mem/thd
2500.0 2.553 2.553 0.000 ( +0.0% ) 5.05 5.15 -1.9% 2.165 2.241
2500.001 2.703 2.703 0.000 ( +0.0% ) 4.54 4.60 -1.3% 2.581 2.661
2500.002 2.643 2.643 0.000 ( +0.0% ) 4.73 4.81 -1.8% 2.578 2.647
2500.01 1.318 1.318 0.000 ( +0.0% ) 8.98 9.29 -3.3% 2.273 2.351
2500.011 1.740 1.740 0.000 ( +0.0% ) 4.97 5.15 -3.6% 2.407 2.503
2500.012 1.581 1.581 0.000 ( +0.0% ) 7.02 7.35 -4.4% 2.362 2.430
2500.1 2.197 2.196 0.001 ( +0.0% ) 5.11 5.14 -0.5% 1.998 2.068
2500.2 2.314 2.313 0.001 ( +0.1% ) 5.85 5.93 -1.3% 1.895 1.984
2500.21 1.182 1.181 0.001 ( +0.1% ) 4.17 4.23 -1.5% 2.201 2.264
2500.211 1.546 1.545 0.001 ( +0.1% ) 3.58 3.63 -1.4% 2.234 2.345
2500.3 2.064 2.062 0.002 ( +0.1% ) 11.56 11.80 -2.0% 1.902 1.976
2500.301 2.637 2.635 0.002 ( +0.1% ) 9.49 9.58 -0.9% 1.836 1.961
2500.31 1.255 1.254 0.001 ( +0.1% ) 18.46 18.93 -2.5% 2.346 2.358
2500.311 1.641 1.640 0.001 ( +0.1% ) 13.02 12.76 +2.0% 2.305 2.424
2500.312 7.159 7.159 0.000 ( +0.0% ) 1.41 1.42 -1.1% 1.701 1.698
2500.313 1.564 1.564 0.000 ( +0.0% ) 6.72 7.12 -5.6% 1.051 1.055
2500.314 1.163 1.163 0.000 ( +0.0% ) 12.95 13.32 -2.8% 2.101 2.185
2500.315 1.757 1.756 0.001 ( +0.1% ) 12.97 13.19 -1.6% 2.325 2.332
2500.316 3.093 3.091 0.002 ( +0.1% ) 2.11 2.17 -2.8% 2.122 2.273
2500.317 1.788 1.787 0.001 ( +0.1% ) 12.71 12.90 -1.5% 2.297 2.322
2500.4 2.226 2.224 0.002 ( +0.1% ) 11.31 11.59 -2.4% 1.832 1.898
2500.401 1.749 1.749 0.000 ( +0.0% ) 9.67 9.86 -1.9% 1.784 1.810
2500.402 2.770 2.768 0.002 ( +0.1% ) 9.15 9.58 -4.6% 1.784 1.911
2500.403 5.080 5.078 0.002 ( +0.0% ) 1.54 1.58 -2.4% 1.835 1.880
2500.404 2.778 2.776 0.002 ( +0.1% ) 9.05 9.26 -2.2% 1.697 1.705
2500.5 4.936 4.936 0.000 ( +0.0% ) 15.55 15.73 -1.1% 1.596 1.585
2500.51 8.960 8.960 0.000 ( +0.0% ) 9.56 9.64 -0.8% 1.539 1.537

@vlimant
Copy link
Contributor Author

vlimant commented Apr 4, 2024

+1

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will now be reviewed by the release team before it's merged. @antoniovilela, @sextonkennedy, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit c9937ca into cms-sw:CMSSW_14_0_X Apr 5, 2024
12 checks passed
@vlimant vlimant deleted the minimal_backport_43485 branch April 7, 2024 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants