Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TrackerAlignment_PayloadInspector: add tag comparator in cylindrical coordinates #44589

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

mmusich
Copy link
Contributor

@mmusich mmusich commented Apr 2, 2024

PR description:

The goal of this PR is to introduce a class to perform tracker alignment payload inspections using cylindrical coordinates (R, φ, Z). It supports both 2 IOVs within the same tag or different tags at the same time.
Also added the new class to the battery of existing unit tests.

PR validation:

Run successfully the package unit tests scram b runtests

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

N/A

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

-code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44589/39758

  • This PR adds an extra 24KB to repository

Code check has found code style and quality issues which could be resolved by applying following patch(s)

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44589/39759

  • This PR adds an extra 24KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

A new Pull Request was created by @mmusich for master.

It involves the following packages:

  • CondCore/AlignmentPlugins (db)

@saumyaphor4252, @cmsbuild, @consuegs, @perrotta, @francescobrivio can you please review it and eventually sign? Thanks.
@rsreds, @PonIlya, @JanChyczynski, @yuanchao, @mmusich this is something you requested to watch as well.
@antoniovilela, @sextonkennedy, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@mmusich
Copy link
Contributor Author

mmusich commented Apr 2, 2024

@cmsbuild, please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff55e0/38547/summary.html
COMMIT: 835a569
CMSSW: CMSSW_14_1_X_2024-04-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44589/38547/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2024

+db

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit 18519e1 into cms-sw:master Apr 4, 2024
11 checks passed
@mmusich mmusich deleted the mm_dev_alignmentPI_cycCoord branch April 4, 2024 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants