-
Notifications
You must be signed in to change notification settings - Fork 4.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TrackerAlignment_PayloadInspector
: add tag comparator in cylindrical coordinates
#44589
Conversation
cms-bot internal usage |
-code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44589/39758
Code check has found code style and quality issues which could be resolved by applying following patch(s)
|
fc47b0e
to
835a569
Compare
+code-checks Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44589/39759
|
A new Pull Request was created by @mmusich for master. It involves the following packages:
@saumyaphor4252, @cmsbuild, @consuegs, @perrotta, @francescobrivio can you please review it and eventually sign? Thanks. cms-bot commands are listed here |
@cmsbuild, please test |
+1 Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ff55e0/38547/summary.html Comparison SummarySummary:
|
+db |
This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @antoniovilela, @rappoccio (and backports should be raised in the release meeting by the corresponding L2) |
+1 |
PR description:
The goal of this PR is to introduce a class to perform tracker alignment payload inspections using cylindrical coordinates (R, φ, Z). It supports both 2 IOVs within the same tag or different tags at the same time.
Also added the new class to the battery of existing unit tests.
PR validation:
Run successfully the package unit tests
scram b runtests
If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:
N/A