Allow inheritance check for non-class types #4459
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TypeWithDict class (our replacement for Reflex::Type) has checks to see if one type inherits from another type. Currently, these checks will throw an exception if one or both of the types in question is not a class. The check should be more general. This pull request changes the check for inheritance to simply return false if one or both of the types is not a class.
Please merge promptly unless there are issues.