Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update L1TUtmTriggerMenu tag in 2024 MC GTs and for Run3 data RelVals #44594

Merged
merged 1 commit into from
Apr 4, 2024

Conversation

saumyaphor4252
Copy link
Contributor

PR description:

The PR updates the L1TUtmTriggerMenu tag from L1Menu_Collisions2024_v1_0_0_xml to L1Menu_Collisions2024_v1_1_0_xml in the following 2024 MC GTs

  • 140X_mcRun3_2024_design_v7
  • 140X_mcRun3_2024_realistic_v8
  • 140X_mcRun3_2024cosmics_realistic_deco_v8
  • 140X_mcRun3_2024cosmics_design_deco_v6

and the Run3 data Relval GT via modification in autoCondModifiers.py.

More details for the request can be found in the relevant CMS Talk post [1].

[1] https://cms-talk.web.cern.ch/t/update-of-the-2024-l1t-menu-tag-l1menu-collisions2024-v1-1-0/37795/

GT Differences with the last ones are here:

PR validation:

Tested with

  • Data RelVal GT: runTheMatrix.py -l 141.044,140.065,141.008,140.022 -j 10 --ibeos
  • 2024 MC GTs: runTheMatrix.py -l 13050.0,13049.0,13046.0,13040.0,12933.0,12841.0,12802.0,12824.0,12834.1,13052.0 --what upgrade -j 10 --ibeos

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Not a backport. Backport to 140X will be soon opened up

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

cms-bot internal usage

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44594/39769

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

A new Pull Request was created by @saumyaphor4252 for master.

It involves the following packages:

  • Configuration/AlCa (alca)

@saumyaphor4252, @consuegs, @cmsbuild, @perrotta can you please review it and eventually sign? Thanks.
@rsreds, @mmusich, @missirol, @yuanchao, @fabiocos, @Martin-Grunewald, @tocheng this is something you requested to watch as well.
@sextonkennedy, @antoniovilela, @rappoccio you are the release manager for this.

cms-bot commands are listed here

@saumyaphor4252
Copy link
Contributor Author

test parameters:

  • workflows = 141.044,140.065,141.008,140.022,13050.0,13049.0,13046.0,13040.0,12933.0,12841.0,12802.0,12824.0,12834.1,13052.0
  • relvals_opt = --what upgrade,standard

@saumyaphor4252
Copy link
Contributor Author

@cmsbuild please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 2, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-424dc5/38556/summary.html
COMMIT: 785fcfa
CMSSW: CMSSW_14_1_X_2024-04-02-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44594/38556/install.sh to create a dev area with all the needed externals and cmssw changes.

  • DAS Queries: The DAS query tests failed, see the summary page for details.

Comparison Summary

Summary:

  • You potentially added 43 lines to the logs
  • Reco comparison results: 109 differences found in the comparisons
  • DQMHistoTests: Total files compared: 61
  • DQMHistoTests: Total histograms compared: 5058993
  • DQMHistoTests: Total failures: 436
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 5058537
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: -3.772000000000001 KiB( 60 files compared)
  • DQMHistoSizes: changed ( 12834.0,... ): -0.164 KiB L1T/L1TStage2uGT
  • Checked 258 log files, 225 edm output root files, 61 DQM output files
  • TriggerResults: found differences in 2 / 59 workflows

@mmusich
Copy link
Contributor

mmusich commented Apr 3, 2024

As far as I understand the changes in the TriggerResults ( found differences in 2 / 59 workflows ) are understood in terms of the tightening of the AXO thresholds at L1:

  • 141.008 (re-HLT):
         Events    Accepted      Gained        Lost       Other  Trigger
         100           1           -          -1           -  HLT_L1AXOVTight_v1
  • 141.044 (re-HLT):
         Events    Accepted      Gained        Lost       Other  Trigger
         100           2           -          -2           -  DST_PFScouting_AXONominal_v1
         100           1           -          -1           -  DST_PFScouting_AXOTight_v1

I don't necessarily understand all the changes in the DQM bin-by-bin comparisons, in particular the ones going on in L1T/ L1TStage2uGT. It would be good if some L1T expert (@caruta, @artlbv ) could take a look and comment.

@caruta
Copy link
Contributor

caruta commented Apr 3, 2024

I don't necessarily understand all the changes in the DQM bin-by-bin comparisons, in particular the ones going on in L1T/ L1TStage2uGT. It would be good if some L1T expert (@caruta, @artlbv ) could take a look and comment.

I've taken a look at the L1T/ L1TStage2uGT DQM plots, and they're all empty (before and after the PR), so probably the differences are in the overflows (not visible).

@artlbv
Copy link
Contributor

artlbv commented Apr 3, 2024

I also don't see anything in the DQM comparisons..

As for the trigger results change this seems compatible with what I got when trying L1Menu v100 vs v101 while testing the AXO PR: #44510 (comment) :

# menu 101
../repackuGT_reHLT_L1_101_L1REPACK_HLT_noCICADA.root
Trigs for 100 events:
DST_PFScouting_AXONominal    0
DST_PFScouting_AXOTight      0
HLT_L1AXOVTight              0
# menu 100
../repackuGT_reHLT_def_L1REPACK_HLT_noCICADA.root
Trigs for 100 events:
DST_PFScouting_AXONominal    2
DST_PFScouting_AXOTight      1
HLT_L1AXOVTight              0

@mmusich
Copy link
Contributor

mmusich commented Apr 3, 2024

I also don't see anything in the DQM comparisons..

there's a y-axis bin re-ordering going on, see e.g:

Screenshot from 2024-04-03 11-59-24

is it expected?

@caruta
Copy link
Contributor

caruta commented Apr 3, 2024

is it expected?

Yes, we've removed some seeds in the new menu, for example the bit 411, so this is why it's missing in the plot after the PR. You can find the list of the removed seeds here.

@perrotta
Copy link
Contributor

perrotta commented Apr 4, 2024

+alca

  • Feedbacks look positive

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants