Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable mkFit for pixelLess iteration (14_0_X) #44616

Merged
merged 1 commit into from
Apr 10, 2024

Conversation

slava77
Copy link
Contributor

@slava77 slava77 commented Apr 4, 2024

backport of #43815

Based on feedback from validation done in 14_0_0_pre2 (https://its.cern.ch/jira/browse/PDMVRELVALS-227; valDB RECOonly campaigns 14_0_0_pre2_mkFit 14_0_0_pre2_mkFit_POGs) and the discussion in the PPD general meeting April 4 https://indico.cern.ch/event/1402177/
the tentative expectation is that this update can go ahead to 14_0_X production.

The final decision is pending until April 11 PPD general meeting.

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

A new Pull Request was created by @slava77 for CMSSW_14_0_X.

It involves the following packages:

  • Configuration/Eras (operations)

@rappoccio, @cmsbuild, @antoniovilela, @fabiocos, @davidlange6 can you please review it and eventually sign? Thanks.
@AnnikaStein, @missirol, @Martin-Grunewald, @makortel, @fabiocos this is something you requested to watch as well.
@rappoccio, @sextonkennedy, @antoniovilela you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

cms-bot internal usage

@slava77
Copy link
Contributor Author

slava77 commented Apr 4, 2024

@cmsbuild please test

@slava77
Copy link
Contributor Author

slava77 commented Apr 4, 2024

@cms-sw/reconstruction-l2 FYI

@slava77
Copy link
Contributor Author

slava77 commented Apr 4, 2024

type tracking

@mandrenguyen
Copy link
Contributor

@cms-sw/reconstruction-l2 FYI

Excellent news! Congratulations to the tracking POG for the long, valiant effort.
Unfortunately, the PR profiling is still not working.
Can you remind us what is the expectation for the timing change in standard workflows?

@slava77
Copy link
Contributor Author

slava77 commented Apr 4, 2024

Can you remind us what is the expectation for the timing change in standard workflows?

From #43580

about 10% reduction in tracking time: 6.6 s -> 6.0 s

this should add up to about 5% in full reco

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 4, 2024

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-ffcbad/38603/summary.html
COMMIT: eb911ff
CMSSW: CMSSW_14_0_X_2024-04-04-1100/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week1/cms-sw/cmssw/44616/38603/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

  • You potentially added 57 lines to the logs
  • Reco comparison results: 28832 differences found in the comparisons
  • DQMHistoTests: Total files compared: 49
  • DQMHistoTests: Total histograms compared: 3346180
  • DQMHistoTests: Total failures: 19188
  • DQMHistoTests: Total nulls: 17
  • DQMHistoTests: Total successes: 3326953
  • DQMHistoTests: Total skipped: 22
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.05500000000000002 KiB( 48 files compared)
  • DQMHistoSizes: changed ( 140.023 ): 0.020 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.043 ): 0.012 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 140.063 ): 0.062 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.042 ): 0.047 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.044 ): -0.074 KiB JetMET/SUSYDQM
  • DQMHistoSizes: changed ( 141.046 ): -0.012 KiB JetMET/SUSYDQM
  • Checked 205 log files, 166 edm output root files, 49 DQM output files
  • TriggerResults: found differences in 2 / 47 workflows

@slava77
Copy link
Contributor Author

slava77 commented Apr 9, 2024

@cms-sw/ppd-l2 @cms-sw/orp-l2
if I understand correctly, this is now urgent.

@malbouis
Copy link
Contributor

malbouis commented Apr 9, 2024

urgent

@antoniovilela
Copy link
Contributor

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next CMSSW_14_0_X IBs (tests are also fine) and once validation in the development release cycle CMSSW_14_1_X is complete. This pull request will be automatically merged.

@cmsbuild cmsbuild merged commit 0f85469 into cms-sw:CMSSW_14_0_X Apr 10, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants