Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Phase2-sim156 Update the scripts to enable run on new scenarios of Phase2 geometry #44662

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

bsunanda
Copy link
Contributor

@bsunanda bsunanda commented Apr 9, 2024

PR description:

Update the scripts to enable run on new scenarios of Phase2 geometry

PR validation:

Use the script to run validation plots with the new scenarios

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

Nothing special

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

cms-bot internal usage

@bsunanda
Copy link
Contributor Author

bsunanda commented Apr 9, 2024

@cmsbuild Please test

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44662/39867

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

A new Pull Request was created by @bsunanda for master.

It involves the following packages:

  • Validation/Geometry (geometry, dqm)

@mdhildreth, @Dr15Jones, @syuvivida, @makortel, @nothingface0, @antoniovagnerini, @rvenditti, @tjavaid, @bsunanda, @civanch can you please review it and eventually sign? Thanks.
@missirol, @fabiocos, @apsallid, @vargasa, @rovere, @rbartek, @youyingli, @rishabhCMS this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

-1

Failed Tests: RelVals-INPUT
Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-e99b76/38693/summary.html
COMMIT: 080a5bc
CMSSW: CMSSW_14_1_X_2024-04-08-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44662/38693/install.sh to create a dev area with all the needed externals and cmssw changes.

RelVals-INPUT

  • 2500.3232500.323_l1DPGNANO130Xrun3/step2_l1DPGNANO130Xrun3.log

Comparison Summary

Summary:

  • You potentially added 85 lines to the logs
  • Reco comparison results: 47 differences found in the comparisons
  • DQMHistoTests: Total files compared: 48
  • DQMHistoTests: Total histograms compared: 3308887
  • DQMHistoTests: Total failures: 3
  • DQMHistoTests: Total nulls: 0
  • DQMHistoTests: Total successes: 3308864
  • DQMHistoTests: Total skipped: 20
  • DQMHistoTests: Total Missing objects: 0
  • DQMHistoSizes: Histogram memory added: 0.0 KiB( 47 files compared)
  • Checked 202 log files, 165 edm output root files, 48 DQM output files
  • TriggerResults: no differences found

@civanch
Copy link
Contributor

civanch commented Apr 9, 2024

Fail likely is not connected with this PR:

@civanch
Copy link
Contributor

civanch commented Apr 9, 2024

+1

no needs to repeat testing. The problem #44666 is known and will be fixed soon

@tjavaid
Copy link

tjavaid commented Apr 21, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (but tests are reportedly failing). This pull request will now be reviewed by the release team before it's merged. @rappoccio, @antoniovilela, @sextonkennedy (and backports should be raised in the release meeting by the corresponding L2)

@rappoccio
Copy link
Contributor

+1

@rappoccio
Copy link
Contributor

merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants