Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ECAL DQM GPU input tag module names for alpaka #44674

Merged

Conversation

kyungminparkdrums
Copy link

@kyungminparkdrums kyungminparkdrums commented Apr 9, 2024

PR description:

This PR changes the input tag names for the ECAL DQM GPU client so that it can be compatible with the new Alpaka HLT menu that will go online in late April. See JIRA ticket CMSHLT-3139 and CMSHLT-3132 for more information.

hltEcalDigisFromGPU -> hltEcalDigis
hltEcalDigisLegacy -> hltEcalDigisSerialSync
hltEcalUncalibRecHitLegacy -> hltEcalUncalibRecHitSerialSync
hltEcalUncalibRecHitFromSoA -> hltEcalUncalibRecHit

PR validation:

Once the HLT menu 2024 V1.1 is online, this PR should be validated on the playback with a run which used the Alpaka HLT menu.

If this PR is a backport please specify the original PR and why you need to backport that PR. If this PR will be backported please specify to which release cycle the backport is meant for:

This is the Master PR. Backports are made to 14_0_X in the PR #44675

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

cms-bot internal usage

@kyungminparkdrums kyungminparkdrums marked this pull request as ready for review April 9, 2024 14:42
@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

+code-checks

Logs: https://cmssdt.cern.ch/SDT/code-checks/cms-sw-PR-44674/39873

  • This PR adds an extra 20KB to repository

@cmsbuild
Copy link
Contributor

cmsbuild commented Apr 9, 2024

A new Pull Request was created by @kyungminparkdrums for master.

It involves the following packages:

  • DQM/Integration (dqm)

@cmsbuild, @nothingface0, @syuvivida, @antoniovagnerini, @rvenditti, @tjavaid can you please review it and eventually sign? Thanks.
@ReyerBand, @francescobrivio, @rchatter, @thomreis, @wang0jin, @argiro, @threus, @batinkov this is something you requested to watch as well.
@antoniovilela, @rappoccio, @sextonkennedy you are the release manager for this.

cms-bot commands are listed here

@tjavaid
Copy link

tjavaid commented Apr 10, 2024

please test

@cmsbuild
Copy link
Contributor

+1

Summary: https://cmssdt.cern.ch/SDT/jenkins-artifacts/pull-request-integration/PR-acea3a/38722/summary.html
COMMIT: 130fdb1
CMSSW: CMSSW_14_1_X_2024-04-09-2300/el8_amd64_gcc12
User test area: For local testing, you can use /cvmfs/cms-ci.cern.ch/week0/cms-sw/cmssw/44674/38722/install.sh to create a dev area with all the needed externals and cmssw changes.

Comparison Summary

Summary:

@tjavaid
Copy link

tjavaid commented Apr 15, 2024

+1

@cmsbuild
Copy link
Contributor

This pull request is fully signed and it will be integrated in one of the next master IBs (tests are also fine). This pull request will now be reviewed by the release team before it's merged. @sextonkennedy, @rappoccio, @antoniovilela (and backports should be raised in the release meeting by the corresponding L2)

@antoniovilela
Copy link
Contributor

+1

@cmsbuild cmsbuild merged commit e04491d into cms-sw:master Apr 15, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants